Closed
Bug 690888
Opened 12 years ago
Closed 12 years ago
[TABLETUI] The height of the menulist should match the buttons
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox9 fixed, fennec9+)
RESOLVED
FIXED
Firefox 9
People
(Reporter: sriram, Assigned: sriram)
References
Details
(Whiteboard: [fixed in aurora][QA?])
Attachments
(1 file)
1.92 KB,
patch
|
mfinkle
:
review+
asa
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The height of the menulist is bigger than the default button size. They both should be the same.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → sriram
Assignee | ||
Comment 1•12 years ago
|
||
This patch fixes the height of the menulist. This also replaces the dropmarker to be consistent with the theme.
Attachment #563815 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Attachment #563815 -
Flags: review?(mark.finkle) → review+
Updated•12 years ago
|
tracking-fennec: --- → 9+
Updated•12 years ago
|
Keywords: checkin-needed
Updated•12 years ago
|
status-firefox9:
--- → affected
Comment 2•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/99eb3dcc3f28
Keywords: checkin-needed
Whiteboard: [inbound]
Comment 3•12 years ago
|
||
Comment on attachment 563815 [details] [diff] [review] Patch Minor cleanup
Attachment #563815 -
Flags: approval-mozilla-aurora?
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/99eb3dcc3f28
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Target Milestone: --- → Firefox 10
Updated•12 years ago
|
Attachment #563815 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 5•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/f9256c7a5685
Whiteboard: [inbound] → [fixed in aurora]
Target Milestone: Firefox 10 → Firefox 9
Comment 6•12 years ago
|
||
I verified menu list on Nightly build from 20110930(ID: Mozilla/5.0 (Android; Linux armv7l; rv:9.0a2) Gecko/20110930 Firefox/9.0a2 Fennec/9.0a2) and also on latest Aurora build(ID: Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111013 Firefox/10.0a1 Fennec/10.0a1), and I cannot see any difference in the menu list height. Can you please provide a screen shot, or some more details about this issue?
Whiteboard: [fixed in aurora] → [fixed in aurora][QA?]
You need to log in
before you can comment on or make changes to this bug.
Description
•