Last Comment Bug 691253 - JavaScript strict warning: chrome://browser/content/browser.js, line 10581: reference to undefined property this._updateFeedTimeout
: JavaScript strict warning: chrome://browser/content/browser.js, line 10581: r...
Status: RESOLVED FIXED
[inbound]
:
Product: Firefox
Classification: Client Software
Component: RSS Discovery and Preview (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 11
Assigned To: Tobias (:Tobbi) Markus
:
: Marco Bonardo [::mak]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-02 23:57 PDT by Richard Newman [:rnewman]
Modified: 2015-10-22 00:33 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (876 bytes, patch)
2011-12-02 08:19 PST, Tobias (:Tobbi) Markus
mak77: review+
Details | Diff | Splinter Review
v1.1 (877 bytes, patch)
2011-12-02 08:34 PST, Tobias (:Tobbi) Markus
mak77: review+
Details | Diff | Splinter Review

Description User image Richard Newman [:rnewman] 2011-10-02 23:57:57 PDT
// If this addition was for the current browser, update the UI. For
    // background browsers, we'll update on tab switch.
    if (browserForLink == gBrowser.selectedBrowser) {
      // Batch updates to avoid updating the UI for multiple onLinkAdded events
      // fired within 100ms of each other.
      clearTimeout(this._updateFeedTimeout);
      this._updateFeedTimeout = setTimeout(this.updateFeeds.bind(this), 100);
    }
  }
};


On current trunk.
Comment 1 User image Tobias (:Tobbi) Markus 2011-12-02 08:19:22 PST
Created attachment 578593 [details] [diff] [review]
patch v1

Who's the right person to request review from?
Comment 2 User image Marco Bonardo [::mak] 2011-12-02 08:25:04 PST
Comment on attachment 578593 [details] [diff] [review]
patch v1

Review of attachment 578593 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the patch, I have one style comment to address, apart that looks fine.

::: browser/base/content/browser.js
@@ +7659,5 @@
>      if (browserForLink == gBrowser.selectedBrowser) {
>        // Batch updates to avoid updating the UI for multiple onLinkAdded events
>        // fired within 100ms of each other.
> +      if(this._updateFeedTimeout)
> +        clearTimeout(this._updateFeedTimeout);

Add a whitespace between if and the parenthesis
Comment 3 User image Tobias (:Tobbi) Markus 2011-12-02 08:34:09 PST
Created attachment 578601 [details] [diff] [review]
v1.1

Fixing the style nit
Comment 4 User image Richard Newman [:rnewman] 2011-12-03 10:09:18 PST
Landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b6c9d4bd1ff
Comment 5 User image Ed Morley [:emorley] 2011-12-04 07:19:58 PST
https://hg.mozilla.org/mozilla-central/rev/9b6c9d4bd1ff
Comment 6 User image boguskyss 2012-08-03 02:28:52 PDT
Comment on attachment 578601 [details] [diff] [review]
v1.1

Review of attachment 578601 [details] [diff] [review]:
-----------------------------------------------------------------

I get this in FIREFOX 14.0.1-- HOW DO I STOP IT!!!!
A script on this page may be busy, or it may have stopped responding. You can stop the script now, or you can continue to see if the script will complete.

Script: chrome://browser/content/browser.js:8047
Comment 7 User image Daniel "warmth" Delgado 2013-12-26 05:21:51 PST
Still having this on Firefox 29.0a1, why?

"script: chrome://browser/content/browser.js:12322"

Note You need to log in before you can comment on or make changes to this bug.