The default bug view has changed. See this FAQ.

JavaScript strict warning: chrome://browser/content/browser.js, line 10581: reference to undefined property this._updateFeedTimeout

RESOLVED FIXED in Firefox 11

Status

()

Firefox
RSS Discovery and Preview
RESOLVED FIXED
6 years ago
2 months ago

People

(Reporter: rnewman, Assigned: Tobbi)

Tracking

Trunk
Firefox 11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
// If this addition was for the current browser, update the UI. For
    // background browsers, we'll update on tab switch.
    if (browserForLink == gBrowser.selectedBrowser) {
      // Batch updates to avoid updating the UI for multiple onLinkAdded events
      // fired within 100ms of each other.
      clearTimeout(this._updateFeedTimeout);
      this._updateFeedTimeout = setTimeout(this.updateFeeds.bind(this), 100);
    }
  }
};


On current trunk.
(Assignee)

Comment 1

5 years ago
Created attachment 578593 [details] [diff] [review]
patch v1

Who's the right person to request review from?
Assignee: nobody → tobbi.bugs
Status: NEW → ASSIGNED
Comment on attachment 578593 [details] [diff] [review]
patch v1

Review of attachment 578593 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the patch, I have one style comment to address, apart that looks fine.

::: browser/base/content/browser.js
@@ +7659,5 @@
>      if (browserForLink == gBrowser.selectedBrowser) {
>        // Batch updates to avoid updating the UI for multiple onLinkAdded events
>        // fired within 100ms of each other.
> +      if(this._updateFeedTimeout)
> +        clearTimeout(this._updateFeedTimeout);

Add a whitespace between if and the parenthesis
Attachment #578593 - Flags: review+
(Assignee)

Comment 3

5 years ago
Created attachment 578601 [details] [diff] [review]
v1.1

Fixing the style nit
Attachment #578593 - Attachment is obsolete: true
Attachment #578601 - Flags: review?(mak77)

Updated

5 years ago
Attachment #578601 - Flags: review?(mak77) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Reporter)

Comment 4

5 years ago
Landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b6c9d4bd1ff
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/9b6c9d4bd1ff
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11

Comment 6

5 years ago
Comment on attachment 578601 [details] [diff] [review]
v1.1

Review of attachment 578601 [details] [diff] [review]:
-----------------------------------------------------------------

I get this in FIREFOX 14.0.1-- HOW DO I STOP IT!!!!
A script on this page may be busy, or it may have stopped responding. You can stop the script now, or you can continue to see if the script will complete.

Script: chrome://browser/content/browser.js:8047
Still having this on Firefox 29.0a1, why?

"script: chrome://browser/content/browser.js:12322"

Comment 8

2 months ago
The same problem on 45.7.0
i think the matter OSes

try to register the library:
Regsvr32 urlmon.dll
You need to log in before you can comment on or make changes to this bug.