Closed Bug 691288 Opened 8 years ago Closed 8 years ago

Clicking on mailto link is broken, it opens an empty compose window


(MailNews Core :: Backend, defect, major)

Not set


(thunderbird7 unaffected, thunderbird8+ fixed, thunderbird9+ fixed, seamonkey2.5 unaffected, seamonkey2.6 fixed, seamonkey2.7 fixed)

Thunderbird 10.0
Tracking Status
thunderbird7 --- unaffected
thunderbird8 + fixed
thunderbird9 + fixed
seamonkey2.5 --- unaffected
seamonkey2.6 --- fixed
seamonkey2.7 --- fixed


(Reporter: Usul, Assigned: Bienvenu)



(Keywords: regression, testcase, verified-aurora)


(1 file, 1 obsolete file)


(I have this in safe-mode with one of the yammer emails, where you can click the reply link to reply)

1) click link that look like :

Results : an empty compose window opens instead of one with a too and subject field pre filled.

Console is empty. Safe-mode doesn't help.

This used to work in 8.Xbeta and is broken for me in 9.xbeta
Keywords: testcase
This may be an issue with cloning of smtp urls not cloning all the parts we've parsed, though I thought the url cloning changes happened a couple releases ago.
A partial regression window, but would be useful to narrow slightly.

Broken: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0a2) Gecko/20110930 Thunderbird/9.0a2

Working: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0a1) Gecko/20110922 Thunderbird/9.0a1
Attached patch proposed fix (obsolete) — Splinter Review
this fixes it - not sure what caused the regression, however.
Assignee: nobody → dbienvenu
Attachment #564184 - Attachment is obsolete: true
Attachment #564208 - Flags: review?(neil)
Duplicate of this bug: 692072
Bug 692072 was on SeaMonkey for Linux-x86_64. Platform ➔ All/All.
OS: Mac OS X → All
Hardware: x86 → All
FYI, (even though this has a patch), because I was curious I did a bisect to track down the regression here.

Even though I don't quite understand why on this one. Bug 677643 was the regressor here.


For reference, the c-c cset I used when testing was:
Depends on: 677643
(bug affects SeaMonkey as well, moving to MailNews Core)
Component: Mail Window Front End → Backend
Product: Thunderbird → MailNews Core
QA Contact: front-end → backend
Comment on attachment 564208 [details] [diff] [review]
fix with unit test

Do you want to patch nsAddbookUrl as well? (Slightly different for some reason, so you'd have to patch it in two places.)
Attachment #564208 - Flags: review?(neil) → review+
(In reply to from comment #10)
> Comment on attachment 564208 [details] [diff] [review] [diff] [details] [review]
> fix with unit test
> Do you want to patch nsAddbookUrl as well? (Slightly different for some
> reason, so you'd have to patch it in two places.)

I can - I'll look at it.
> Even though I don't quite understand why on this one

Because that patch added a clone call and apparently mailnews URIs had a broken clone implementation?
fixed on trunk

I'll deal with nsAddbokUrl in a different bug.

And yes, bz is obviously right. Clone was broken for mailto urls but it didn't matter before. Now we have a unit test for it.
Group: core-security
Closed: 8 years ago
Resolution: --- → FIXED
Group: core-security
Target Milestone: --- → Thunderbird 10.0
I VERIFY that the duplicate bug 692072 (see comment #6) has now disappeared:

BAD:  Mozilla/5.0 (X11; Linux x86_64; rv:10.0a1) Gecko/20111007 Firefox/10.0a1 SeaMonkey/2.7a1 ID:20111007003005
GOOD: Mozilla/5.0 (X11; Linux x86_64; rv:10.0a1) Gecko/20111008 Firefox/10.0a1 SeaMonkey/2.7a1 ID:20111008003005

Clicking the link in the minimum testcase now opens an email-compose window with "To:" and "Subject:" fields filled-in, while they were empty before.

I didn't test anything with Shredder: if the bug still appears in a build of Thunderbird 10.0a1 or SeaMonkey 2.7a1 for any platform, but started before comment #13, please mention here or in a followup bug exactly what you did, what you saw, and include your user-agent string and if possible your "Build ID" timestamp, as obtained by means of the Nightly Tester Tools extension or from the *.txt file which accompanies the build archive on the FTP server.
oops: ... "started _after_ comment #13", of course. :-/
Attachment #564208 - Flags: approval-comm-aurora?
Comment on attachment 564208 [details] [diff] [review]
fix with unit test

the regressing moz-central change also landed on mozilla-beta, which is why we need the fix to land on comm-beta as well.
Attachment #564208 - Flags: approval-comm-beta?
Attachment #564208 - Flags: approval-comm-beta?
Attachment #564208 - Flags: approval-comm-beta+
Attachment #564208 - Flags: approval-comm-aurora?
Attachment #564208 - Flags: approval-comm-aurora+
Duplicate of this bug: 694194
(In reply to Mark Banner (:standard8) from comment #17)
> Checked into branches:

Mozilla/5.0 (X11; Linux x86_64; rv:9.0a2) Gecko/20111013 Firefox/9.0a2 SeaMonkey/2.6a2

The bug has also disappeared from this build of SeaMonkey-aurora.
Comment on attachment 564208 [details] [diff] [review]
fix with unit test

Adding back approval flag that was mistakenly removed. dkl
Attachment #564208 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.