Clicking on mailto link is broken, it opens an empty compose window

VERIFIED FIXED in Thunderbird 10.0

Status

MailNews Core
Backend
--
major
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: Usul, Assigned: Bienvenu)

Tracking

({regression, testcase, verified-aurora})

Thunderbird 10.0
regression, testcase, verified-aurora

Thunderbird Tracking Flags

(thunderbird7 unaffected, thunderbird8+ fixed, thunderbird9+ fixed, seamonkey2.5 unaffected, seamonkey2.6 fixed, seamonkey2.7 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 564156 [details]
Email showing up the issue

Str:

(I have this in safe-mode with one of the yammer emails, where you can click the reply link to reply)

1) click link that look like : mailto:yammer+re+118111379+zzz@yammer.com?subject=somesubject

Results : an empty compose window opens instead of one with a too and subject field pre filled.

Console is empty. Safe-mode doesn't help.

This used to work in 8.Xbeta and is broken for me in 9.xbeta
(Reporter)

Updated

6 years ago
Keywords: testcase
(Assignee)

Comment 2

6 years ago
This may be an issue with cloning of smtp urls not cloning all the parts we've parsed, though I thought the url cloning changes happened a couple releases ago.
A partial regression window, but would be useful to narrow slightly.


Broken: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0a2) Gecko/20110930 Thunderbird/9.0a2

Working: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0a1) Gecko/20110922 Thunderbird/9.0a1
tracking-thunderbird10: ? → +
tracking-thunderbird9: ? → +
Keywords: regressionwindow-wanted
(Assignee)

Comment 4

6 years ago
Created attachment 564184 [details] [diff] [review]
proposed fix

this fixes it - not sure what caused the regression, however.
Assignee: nobody → dbienvenu
(Assignee)

Comment 5

6 years ago
Created attachment 564208 [details] [diff] [review]
fix with unit test
Attachment #564184 - Attachment is obsolete: true
Attachment #564208 - Flags: review?(neil)
(Assignee)

Updated

6 years ago
Duplicate of this bug: 692072
Bug 692072 was on SeaMonkey for Linux-x86_64. Platform ➔ All/All.
OS: Mac OS X → All
Hardware: x86 → All
status-thunderbird7: --- → unaffected
tracking-thunderbird8: --- → +
FYI, (even though this has a patch), because I was curious I did a bisect to track down the regression here.

Even though I don't quite understand why on this one. Bug 677643 was the regressor here.

Specifically: http://hg.mozilla.org/mozilla-central/rev/cadb12b21740

For reference, the c-c cset I used when testing was: http://hg.mozilla.org/comm-central/rev/feb47379243c
Depends on: 677643
(bug affects SeaMonkey as well, moving to MailNews Core)
Component: Mail Window Front End → Backend
Product: Thunderbird → MailNews Core
QA Contact: front-end → backend
Comment on attachment 564208 [details] [diff] [review]
fix with unit test

Do you want to patch nsAddbookUrl as well? (Slightly different for some reason, so you'd have to patch it in two places.)
Attachment #564208 - Flags: review?(neil) → review+
(Assignee)

Comment 11

6 years ago
(In reply to neil@parkwaycc.co.uk from comment #10)
> Comment on attachment 564208 [details] [diff] [review] [diff] [details] [review]
> fix with unit test
> 
> Do you want to patch nsAddbookUrl as well? (Slightly different for some
> reason, so you'd have to patch it in two places.)

I can - I'll look at it.
> Even though I don't quite understand why on this one

Because that patch added a clone call and apparently mailnews URIs had a broken clone implementation?
(Assignee)

Comment 13

6 years ago
fixed on trunk http://hg.mozilla.org/comm-central/rev/866b5e6fdea1

I'll deal with nsAddbokUrl in a different bug.

And yes, bz is obviously right. Clone was broken for mailto urls but it didn't matter before. Now we have a unit test for it.
Group: core-security
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Group: core-security
Target Milestone: --- → Thunderbird 10.0
I VERIFY that the duplicate bug 692072 (see comment #6) has now disappeared:

BAD:  Mozilla/5.0 (X11; Linux x86_64; rv:10.0a1) Gecko/20111007 Firefox/10.0a1 SeaMonkey/2.7a1 ID:20111007003005
GOOD: Mozilla/5.0 (X11; Linux x86_64; rv:10.0a1) Gecko/20111008 Firefox/10.0a1 SeaMonkey/2.7a1 ID:20111008003005

Clicking the link in the minimum testcase https://bug692072.bugzilla.mozilla.org/attachment.cgi?id=564885 now opens an email-compose window with "To:" and "Subject:" fields filled-in, while they were empty before.

I didn't test anything with Shredder: if the bug still appears in a build of Thunderbird 10.0a1 or SeaMonkey 2.7a1 for any platform, but started before comment #13, please mention here or in a followup bug exactly what you did, what you saw, and include your user-agent string and if possible your "Build ID" timestamp, as obtained by means of the Nightly Tester Tools extension or from the *.txt file which accompanies the build archive on the FTP server.
Status: RESOLVED → VERIFIED
status-seamonkey2.5: --- → unaffected
status-seamonkey2.6: --- → affected
status-seamonkey2.7: --- → fixed
status-thunderbird9: --- → affected
oops: ... "started _after_ comment #13", of course. :-/
(Assignee)

Updated

6 years ago
Attachment #564208 - Flags: approval-comm-aurora?
(Assignee)

Comment 16

6 years ago
Comment on attachment 564208 [details] [diff] [review]
fix with unit test

the regressing moz-central change also landed on mozilla-beta, which is why we need the fix to land on comm-beta as well.
Attachment #564208 - Flags: approval-comm-beta?
Attachment #564208 - Flags: approval-comm-beta?
Attachment #564208 - Flags: approval-comm-beta+
Attachment #564208 - Flags: approval-comm-aurora?
Attachment #564208 - Flags: approval-comm-aurora+
Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/132257a4c0a0
http://hg.mozilla.org/releases/comm-beta/rev/db026f4ce3e8
status-thunderbird8: --- → fixed
status-thunderbird9: affected → fixed
tracking-thunderbird10: + → ---

Updated

6 years ago
Duplicate of this bug: 694194
(In reply to Mark Banner (:standard8) from comment #17)
> Checked into branches:
> 
> http://hg.mozilla.org/releases/comm-aurora/rev/132257a4c0a0
> http://hg.mozilla.org/releases/comm-beta/rev/db026f4ce3e8

Mozilla/5.0 (X11; Linux x86_64; rv:9.0a2) Gecko/20111013 Firefox/9.0a2 SeaMonkey/2.6a2

The bug has also disappeared from this build of SeaMonkey-aurora.
status-seamonkey2.6: affected → fixed
Keywords: regression, regressionwindow-wanted, testcase → verified-aurora
Keywords: regression, testcase
Comment on attachment 564208 [details] [diff] [review]
fix with unit test

Adding back approval flag that was mistakenly removed. dkl
Attachment #564208 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.