Created attachment 564156 [details] Email showing up the issue Str: (I have this in safe-mode with one of the yammer emails, where you can click the reply link to reply) 1) click link that look like : mailto:firstname.lastname@example.org?subject=somesubject Results : an empty compose window opens instead of one with a too and subject field pre filled. Console is empty. Safe-mode doesn't help. This used to work in 8.Xbeta and is broken for me in 9.xbeta
This may be an issue with cloning of smtp urls not cloning all the parts we've parsed, though I thought the url cloning changes happened a couple releases ago.
A partial regression window, but would be useful to narrow slightly. Broken: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0a2) Gecko/20110930 Thunderbird/9.0a2 Working: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0a1) Gecko/20110922 Thunderbird/9.0a1
Created attachment 564184 [details] [diff] [review] proposed fix this fixes it - not sure what caused the regression, however.
Created attachment 564208 [details] [diff] [review] fix with unit test
Bug 692072 was on SeaMonkey for Linux-x86_64. Platform ➔ All/All.
FYI, (even though this has a patch), because I was curious I did a bisect to track down the regression here. Even though I don't quite understand why on this one. Bug 677643 was the regressor here. Specifically: http://hg.mozilla.org/mozilla-central/rev/cadb12b21740 For reference, the c-c cset I used when testing was: http://hg.mozilla.org/comm-central/rev/feb47379243c
(bug affects SeaMonkey as well, moving to MailNews Core)
Comment on attachment 564208 [details] [diff] [review] fix with unit test Do you want to patch nsAddbookUrl as well? (Slightly different for some reason, so you'd have to patch it in two places.)
(In reply to email@example.com from comment #10) > Comment on attachment 564208 [details] [diff] [review] [diff] [details] [review] > fix with unit test > > Do you want to patch nsAddbookUrl as well? (Slightly different for some > reason, so you'd have to patch it in two places.) I can - I'll look at it.
> Even though I don't quite understand why on this one Because that patch added a clone call and apparently mailnews URIs had a broken clone implementation?
fixed on trunk http://hg.mozilla.org/comm-central/rev/866b5e6fdea1 I'll deal with nsAddbokUrl in a different bug. And yes, bz is obviously right. Clone was broken for mailto urls but it didn't matter before. Now we have a unit test for it.
I VERIFY that the duplicate bug 692072 (see comment #6) has now disappeared: BAD: Mozilla/5.0 (X11; Linux x86_64; rv:10.0a1) Gecko/20111007 Firefox/10.0a1 SeaMonkey/2.7a1 ID:20111007003005 GOOD: Mozilla/5.0 (X11; Linux x86_64; rv:10.0a1) Gecko/20111008 Firefox/10.0a1 SeaMonkey/2.7a1 ID:20111008003005 Clicking the link in the minimum testcase https://bug692072.bugzilla.mozilla.org/attachment.cgi?id=564885 now opens an email-compose window with "To:" and "Subject:" fields filled-in, while they were empty before. I didn't test anything with Shredder: if the bug still appears in a build of Thunderbird 10.0a1 or SeaMonkey 2.7a1 for any platform, but started before comment #13, please mention here or in a followup bug exactly what you did, what you saw, and include your user-agent string and if possible your "Build ID" timestamp, as obtained by means of the Nightly Tester Tools extension or from the *.txt file which accompanies the build archive on the FTP server.
oops: ... "started _after_ comment #13", of course. :-/
Comment on attachment 564208 [details] [diff] [review] fix with unit test the regressing moz-central change also landed on mozilla-beta, which is why we need the fix to land on comm-beta as well.
Checked into branches: http://hg.mozilla.org/releases/comm-aurora/rev/132257a4c0a0 http://hg.mozilla.org/releases/comm-beta/rev/db026f4ce3e8
(In reply to Mark Banner (:standard8) from comment #17) > Checked into branches: > > http://hg.mozilla.org/releases/comm-aurora/rev/132257a4c0a0 > http://hg.mozilla.org/releases/comm-beta/rev/db026f4ce3e8 Mozilla/5.0 (X11; Linux x86_64; rv:9.0a2) Gecko/20111013 Firefox/9.0a2 SeaMonkey/2.6a2 The bug has also disappeared from this build of SeaMonkey-aurora.
Comment on attachment 564208 [details] [diff] [review] fix with unit test Adding back approval flag that was mistakenly removed. dkl