Closed Bug 691320 Opened 14 years ago Closed 14 years ago

typo in GroupItems.newTab from panorama

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 10

People

(Reporter: tabmix.onemen, Assigned: raymondlee)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 1 obsolete file)

in the function GroupItems.newTab there is a typo: let targetGroupItem; // find first visible non-app tab in the tabbar. gBrowser.visibleTabs.some(function(tab) { if (!tab.pinned && tab != tabItem.tab) { if (tab._tabViewTabItem) { - if (!tab._tabViewTabItem.parent && !tab._tabViewTabItem.parent.hidden) { + if (tab._tabViewTabItem.parent && !tab._tabViewTabItem.parent.hidden) { // the first visible tab belongs to a group, add the new tabItem to // that group targetGroupItem = tab._tabViewTabItem.parent; } } return true; } return false; });
Hi reporter, which version did you find the typo? Looking at the mozilla central, everything looks right? http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabview/groupitems.js#2387
(In reply to Raymond Lee [:raymondlee] from comment #1) > Hi reporter, which version did you find the typo? > > Looking at the mozilla central, everything looks right? > http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabview/ > groupitems.js#2387 I see what you mean now. the if condition should use tab._tabViewTabItem.parent.
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #564447 - Flags: review?(ttaubert)
Comment on attachment 564447 [details] [diff] [review] v1 Review of attachment 564447 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Can you please push it to try to make sure we don't rely on that wrong condition?
Attachment #564447 - Flags: review?(ttaubert) → review+
Pushed to try and waiting for the results https://tbpl.mozilla.org/?tree=Try&rev=5663f9b06052
Passed Try!
Attachment #564447 - Attachment is obsolete: true
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 10
Version: unspecified → Trunk
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: