691320 - typo in GroupItems.newTab from panorama

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[tabmix.onemen]

in the function GroupItems.newTab there is a typo:

  let targetGroupItem;
  // find first visible non-app tab in the tabbar.
  gBrowser.visibleTabs.some(function(tab) {
    if (!tab.pinned && tab != tabItem.tab) {
      if (tab._tabViewTabItem) {
-       if (!tab._tabViewTabItem.parent && !tab._tabViewTabItem.parent.hidden) {
+       if (tab._tabViewTabItem.parent && !tab._tabViewTabItem.parent.hidden) {
          // the first visible tab belongs to a group, add the new tabItem to 
          // that group
          targetGroupItem = tab._tabViewTabItem.parent;
        }
      }
      return true;
    }
    return false;
  });

Comment 1

[Raymond Lee [:raymondlee]]

Hi reporter, which version did you find the typo?

Looking at the mozilla central, everything looks right?
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabview/groupitems.js#2387

Comment 2

[Raymond Lee [:raymondlee]]

(In reply to Raymond Lee [:raymondlee] from comment #1)
> Hi reporter, which version did you find the typo?
> 
> Looking at the mozilla central, everything looks right?
> http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabview/
> groupitems.js#2387

I see what you mean now. the if condition should use tab._tabViewTabItem.parent.

Comment 3

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 564447 [details] [diff] [review]
v1

Review of attachment 564447 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Can you please push it to try to make sure we don't rely on that wrong condition?

Comment 5

[Raymond Lee [:raymondlee]]

Pushed to try and waiting for the results
https://tbpl.mozilla.org/?tree=Try&rev=5663f9b06052

Comment 6

[Raymond Lee [:raymondlee]]

Attachment: Patch for checkin

Passed Try!

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/bce52912af92

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/bce52912af92