The default bug view has changed. See this FAQ.

typo in GroupItems.newTab from panorama

RESOLVED FIXED in Firefox 10

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: tabmix.onemen, Assigned: raymondlee)

Tracking

Trunk
Firefox 10

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
in the function GroupItems.newTab there is a typo:

  let targetGroupItem;
  // find first visible non-app tab in the tabbar.
  gBrowser.visibleTabs.some(function(tab) {
    if (!tab.pinned && tab != tabItem.tab) {
      if (tab._tabViewTabItem) {
-       if (!tab._tabViewTabItem.parent && !tab._tabViewTabItem.parent.hidden) {
+       if (tab._tabViewTabItem.parent && !tab._tabViewTabItem.parent.hidden) {
          // the first visible tab belongs to a group, add the new tabItem to 
          // that group
          targetGroupItem = tab._tabViewTabItem.parent;
        }
      }
      return true;
    }
    return false;
  });
(Assignee)

Comment 1

6 years ago
Hi reporter, which version did you find the typo?

Looking at the mozilla central, everything looks right?
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabview/groupitems.js#2387
(Assignee)

Comment 2

6 years ago
(In reply to Raymond Lee [:raymondlee] from comment #1)
> Hi reporter, which version did you find the typo?
> 
> Looking at the mozilla central, everything looks right?
> http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabview/
> groupitems.js#2387

I see what you mean now. the if condition should use tab._tabViewTabItem.parent.
(Assignee)

Comment 3

6 years ago
Created attachment 564447 [details] [diff] [review]
v1
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #564447 - Flags: review?(ttaubert)
Comment on attachment 564447 [details] [diff] [review]
v1

Review of attachment 564447 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Can you please push it to try to make sure we don't rely on that wrong condition?
Attachment #564447 - Flags: review?(ttaubert) → review+
(Assignee)

Comment 5

6 years ago
Pushed to try and waiting for the results
https://tbpl.mozilla.org/?tree=Try&rev=5663f9b06052
(Assignee)

Comment 6

6 years ago
Created attachment 564490 [details] [diff] [review]
Patch for checkin

Passed Try!
Attachment #564447 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/bce52912af92
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 10
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/bce52912af92
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.