691818 - AndroidManifest.xml implies that camera and autofocus are required

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Bug 659188 added "uses-feature" declarations for camera and camera.autofocus.  These should be marked required="false", otherwise the Android Market might not show Fennec to devices without camera and autofocus hardware:
http://developer.android.com/guide/topics/manifest/uses-feature-element.html#declared

(This is similar to bug 621262, which fixed the same problem with GPS.)

This patch also cleans up two permission declarations that were accidentally added twice.

Requesting tracking-fennec because this is a regression in Fennec 9 and we might want to fix it on the Aurora branch.

Comment 1

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2701aeb5ad8d

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 564599 [details] [diff] [review]
patch

Reqesting approval for Aurora 9.  This simple metadata change in our Android package manifest fixes a regression in Firefox 9 that might make Firefox unavailable in the Android Market on some devices.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/2701aeb5ad8d

Comment 4

[Christopher Blizzard (:blizzard)]

Comment on attachment 564599 [details] [diff] [review]
patch

Approved for Aurora (Update 9).  Please land as soon as possible.