Closed Bug 691818 Opened 9 years ago Closed 9 years ago

AndroidManifest.xml implies that camera and autofocus are required

Categories

(Core :: Widget: Android, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10
Tracking Status
firefox8 --- unaffected
firefox9 --- affected
firefox10 --- fixed

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: regression, Whiteboard: [pushed])

Attachments

(1 file)

Attached patch patchSplinter Review
Bug 659188 added "uses-feature" declarations for camera and camera.autofocus.  These should be marked required="false", otherwise the Android Market might not show Fennec to devices without camera and autofocus hardware:
http://developer.android.com/guide/topics/manifest/uses-feature-element.html#declared

(This is similar to bug 621262, which fixed the same problem with GPS.)

This patch also cleans up two permission declarations that were accidentally added twice.

Requesting tracking-fennec because this is a regression in Fennec 9 and we might want to fix it on the Aurora branch.
Attachment #564599 - Flags: review?(blassey.bugs)
Attachment #564599 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2701aeb5ad8d
Whiteboard: [has patch] → [pushed]
Target Milestone: --- → mozilla10
Comment on attachment 564599 [details] [diff] [review]
patch

Reqesting approval for Aurora 9.  This simple metadata change in our Android package manifest fixes a regression in Firefox 9 that might make Firefox unavailable in the Android Market on some devices.
Attachment #564599 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/2701aeb5ad8d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 564599 [details] [diff] [review]
patch

Approved for Aurora (Update 9).  Please land as soon as possible.
Attachment #564599 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.