Closed Bug 692031 Opened 8 years ago Closed 8 years ago

DOMTemplate async loops do not drop the loop element

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 10

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file)

See comment in
/devtools/browser/devtools/shared/test/browser_templater_basic.js

The <loop> element is special when used with foreach, in that it should be removed on processing. When the data is asynchronous, the loop element is not dropped.

Compare the 'loopElement' and 'asyncLoopElement' tests.
Attached patch upload 1Splinter Review
This patch fixes the bug is question and tidies up a few minor things. It also uncomments the test for this bug.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #565619 - Flags: review?(rcampbell)
Comment on attachment 565619 [details] [diff] [review]
upload 1

okay!
Attachment #565619 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/cf6f3b701980
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.