The default bug view has changed. See this FAQ.

DOMTemplate async loops do not drop the loop element

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

Trunk
Firefox 10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment)

See comment in
/devtools/browser/devtools/shared/test/browser_templater_basic.js

The <loop> element is special when used with foreach, in that it should be removed on processing. When the data is asynchronous, the loop element is not dropped.

Compare the 'loopElement' and 'asyncLoopElement' tests.
Created attachment 565619 [details] [diff] [review]
upload 1

This patch fixes the bug is question and tidies up a few minor things. It also uncomments the test for this bug.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #565619 - Flags: review?(rcampbell)
Depends on: 691012
Try log:
https://tbpl.mozilla.org/?tree=Try&rev=f2eedda104b1
Comment on attachment 565619 [details] [diff] [review]
upload 1

okay!
Attachment #565619 - Flags: review?(rcampbell) → review+
upload 1: https://hg.mozilla.org/integration/fx-team/rev/cf6f3b701980
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/cf6f3b701980
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
You need to log in before you can comment on or make changes to this bug.