Closed
Bug 692031
Opened 12 years ago
Closed 12 years ago
DOMTemplate async loops do not drop the loop element
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 10
People
(Reporter: jwalker, Assigned: jwalker)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file)
|
3.72 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
See comment in /devtools/browser/devtools/shared/test/browser_templater_basic.js The <loop> element is special when used with foreach, in that it should be removed on processing. When the data is asynchronous, the loop element is not dropped. Compare the 'loopElement' and 'asyncLoopElement' tests.
|
Assignee | |
Comment 1•12 years ago
|
||
This patch fixes the bug is question and tidies up a few minor things. It also uncomments the test for this bug.
|
|
Assignee | |
Comment 2•12 years ago
|
||
Try log: https://tbpl.mozilla.org/?tree=Try&rev=f2eedda104b1
|
||
Comment 3•12 years ago
|
||
Comment on attachment 565619 [details] [diff] [review] upload 1 okay!
Attachment #565619 -
Flags: review?(rcampbell) → review+
|
|
||
Comment 4•12 years ago
|
||
upload 1: https://hg.mozilla.org/integration/fx-team/rev/cf6f3b701980
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cf6f3b701980
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
|
||
Updated•5 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•