Closed Bug 691012 Opened 8 years ago Closed 8 years ago

DOMTemplate needs chrome tests

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 10

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 2 obsolete files)

Summary: DOMTemplate needs in chrome tests → DOMTemplate needs chrome tests
Attached patch upload 1 (obsolete) — Splinter Review
Rob back in bug 684958 comment 11, you asked for templater tests. Theses are they. One of the tests is commented out because it uncovered bug 692031. I'll be uploading a patch there to soon.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #565618 - Flags: review?(rcampbell)
Pls ignore typos in comments. It's late. :)
Attached patch upload 2 (obsolete) — Splinter Review
Minor tweaks as a result of the changes in bug 692424.

We're deleting an HTML file that was added in bug 692424 - it's just an easy way of getting out of make wanting HTML files to copy. Call me lazy, I'm sure there is a better way, but this has the same effect and it works :)
Attachment #565618 - Attachment is obsolete: true
Attachment #565618 - Flags: review?(rcampbell)
Comment on attachment 566239 [details] [diff] [review]
upload 2

diff --git a/browser/devtools/shared/test/browser_templater_basic.html b/browser/devtools/shared/test/browser_templater_basic.html
new file mode 100644

+</html>
\ No newline at end of file

good! thanks for the tests! :)
Attachment #566239 - Flags: review+
Attached patch upload 3Splinter Review
Adds newline :)
Attachment #566239 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/4322ee96f796
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.