DOMTemplate needs chrome tests

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

Trunk
Firefox 10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 2 obsolete attachments)

These tests should be ported:
https://github.com/joewalker/domtemplate/blob/master/test/index.html
Summary: DOMTemplate needs in chrome tests → DOMTemplate needs chrome tests
Created attachment 565618 [details] [diff] [review]
upload 1

Rob back in bug 684958 comment 11, you asked for templater tests. Theses are they. One of the tests is commented out because it uncovered bug 692031. I'll be uploading a patch there to soon.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #565618 - Flags: review?(rcampbell)
Pls ignore typos in comments. It's late. :)
Blocks: 692031
Depends on: 692424
Created attachment 566239 [details] [diff] [review]
upload 2

Minor tweaks as a result of the changes in bug 692424.

We're deleting an HTML file that was added in bug 692424 - it's just an easy way of getting out of make wanting HTML files to copy. Call me lazy, I'm sure there is a better way, but this has the same effect and it works :)
Attachment #565618 - Attachment is obsolete: true
Attachment #565618 - Flags: review?(rcampbell)
Comment on attachment 566239 [details] [diff] [review]
upload 2

diff --git a/browser/devtools/shared/test/browser_templater_basic.html b/browser/devtools/shared/test/browser_templater_basic.html
new file mode 100644

+</html>
\ No newline at end of file

good! thanks for the tests! :)
Attachment #566239 - Flags: review+
Created attachment 566526 [details] [diff] [review]
upload 3

Adds newline :)
Attachment #566239 - Attachment is obsolete: true
Try log:
https://tbpl.mozilla.org/?tree=Try&rev=f2eedda104b1
upload 3: https://hg.mozilla.org/integration/fx-team/rev/4322ee96f796
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/4322ee96f796
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Blocks: 704918
You need to log in before you can comment on or make changes to this bug.