Closed
Bug 692160
Opened 13 years ago
Closed 6 years ago
Select elements should use prompt-button styles
Categories
(Firefox for Android Graveyard :: General, defect, P3)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: wesj, Unassigned)
References
Details
Attachments
(1 file)
|
1.83 KB,
patch
|
Details | Diff | Splinter Review |
Selects don't use normal button classes and so their buttons look wrong to me:
http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/browser.xul#624
Instead we should have a box with a "prompt-buttons" class and the buttons should have "prompt-button" classes on them.
|
||
Updated•13 years ago
|
Priority: -- → P3
|
Reporter | |
Comment 1•13 years ago
|
||
This works well for me. Looks fine in Gingerbread/Froyo as well. Using the test case here:
https://bug691758.bugzilla.mozilla.org/attachment.cgi?id=564553
Assignee: nobody → wjohnston
|
|
Reporter | |
Comment 2•13 years ago
|
||
Screenshots from desktop are at:
http://people.mozilla.com/~wjohnston/screenshots/selectDialog/
|
||
Comment 3•13 years ago
|
||
The "done" button in the honeycomb screenshot blends into the list items
Why do we even have the the "Done" button? I thought we removed it.
|
||
Comment 4•13 years ago
|
||
"Done" is needed for <select multiple>.
|
|
Reporter | |
Updated•12 years ago
|
Assignee: wjohnston → nobody
|
||
Comment 5•6 years ago
|
||
Closing all opened bug in a graveyard component
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•