Created attachment 565082 [details] screenshot The dialog is currently: Confirm Dialog Preferences Prevent this page from creating addition dialogs [Cancel] / [OK] I guess this dialog is for preventing abuse of dialogs that don't have internal checkboxes, such as window.print() and window.showModalDialog(). window.print() is not subject to pop-up blocker control, so fixing bug 675574 will not (by itself) make this dialog irrelevant. Bug 600189 shows one situation where this dialog appears. Presumably http://hg.mozilla.org/mozilla-central/annotate/0f872fecb5a8/dom/tests/mochitest/bugs/test_bug61098.html shows another. Relevant code: http://hg.mozilla.org/mozilla-central/file/32536d199fcf/toolkit/locales/en-US/chrome/global/commonDialogs.properties#l17 http://hg.mozilla.org/mozilla-central/file/0f872fecb5a8/dom/base/nsGlobalWindow.cpp#l2665 (looks like the body of this dialog is the same string as the checkbox inside repeated alerts)
Component: General → DOM
Product: Firefox → Core
QA Contact: general → general
Hey Dolske, do you know what this dialog is for and when it appears?
Boriss: you can see it by clicking the link at http://gavinsharp.com/tmp/abuse.html , and then accepting the prompt a few times.
Gavin, I get the in-alert checkbox for your testcase.
Oh, sorry, I forgot what this was actually about. And I didn't read comment 0 properly, since you already explain it in detail :) http://gavinsharp.com/tmp/abuse-print.html is an easy-to-use testcase (click the link then cancel the dialog ~10 times).
Created attachment 594310 [details] Mockup: Prevent Page Dialog as doorhanger Thanks Gavin! Could we make this shit into a page-modal doorhanger (see attached)? We already have the icon in mxr: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/icons/ Incidentally, UX is working on a non-modal print dialog at the moment, so if that's the only way this appears it may be a matter of time anyway
If the default is 10 times before we show it (and it's not just part of the test page), it should be reduced to 2 or 3 as the threshold. As for the text, how about: Prevent this page from creating additional dialogs? [Allow] [Prevent] Anyway, this is a very obscure part of our browser, I don't think we need to invest a lot of time in this — it mostly just needs to work if anyone gets hijacked. If we can easily make it page-modal instead of window modal, that's great too.
While you're there, separate the browser UI from the page's. Leave the string sent to alert/confirm/etc. in the white area, but move the "Prevent this page from creating additional dialogs?" into the grey area, where the buttons go.
Since this bug is about the case where "Prevent this page from creating additional dialogs" is a separate dialog, I filed bug 779155 for walf's suggestion.
You need to log in before you can comment on or make changes to this bug.