692331 - "Confirm Dialog Preference: Prevent this page from creating additional dialogs" dialog needs UX love

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Jesse Ruderman]

Attachment: screenshot

The dialog is currently:

           Confirm Dialog Preferences
  Prevent this page from creating addition dialogs
                 [Cancel] / [OK]

I guess this dialog is for preventing abuse of dialogs that don't have internal checkboxes, such as window.print() and window.showModalDialog().

window.print() is not subject to pop-up blocker control, so fixing bug 675574 will not (by itself) make this dialog irrelevant.

Bug 600189 shows one situation where this dialog appears.  Presumably http://hg.mozilla.org/mozilla-central/annotate/0f872fecb5a8/dom/tests/mochitest/bugs/test_bug61098.html shows another.

Relevant code:
http://hg.mozilla.org/mozilla-central/file/32536d199fcf/toolkit/locales/en-US/chrome/global/commonDialogs.properties#l17
http://hg.mozilla.org/mozilla-central/file/0f872fecb5a8/dom/base/nsGlobalWindow.cpp#l2665
(looks like the body of this dialog is the same string as the checkbox inside repeated alerts)

Comment 1

[Jennifer Morrow [:Boriss] (UX)]

Hey Dolske, do you know what this dialog is for and when it appears?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Boriss: you can see it by clicking the link at http://gavinsharp.com/tmp/abuse.html , and then accepting the prompt a few times.

Comment 3

[Jesse Ruderman]

Gavin, I get the in-alert checkbox for your testcase.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Oh, sorry, I forgot what this was actually about. And I didn't read comment 0 properly, since you already explain it in detail :)

http://gavinsharp.com/tmp/abuse-print.html is an easy-to-use testcase (click the link then cancel the dialog ~10 times).

Comment 5

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Mockup: Prevent Page Dialog as doorhanger

Thanks Gavin!  Could we make this shit into a page-modal doorhanger (see attached)?  We already have the icon in mxr: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/icons/

Incidentally, UX is working on a non-modal print dialog at the moment, so if that's the only way this appears it may be a matter of time anyway

Comment 6

[Alex Limi (:limi) — Firefox UX Team]

If the default is 10 times before we show it (and it's not just part of the test page), it should be reduced to 2 or 3 as the threshold.

As for the text, how about:

  Prevent this page from creating additional dialogs?
  [Allow] [Prevent]

Anyway, this is a very obscure part of our browser, I don't think we need to invest a lot of time in this — it mostly just needs to work if anyone gets hijacked. If we can easily make it page-modal instead of window modal, that's great too.

Comment 7

[walf]

While you're there, separate the browser UI from the page's. Leave the string sent to alert/confirm/etc. in the white area, but move the "Prevent this page from creating additional dialogs?" into the grey area, where the buttons go.

Comment 8

[Jesse Ruderman]

Since this bug is about the case where "Prevent this page from creating additional dialogs" is a separate dialog, I filed bug 779155 for walf's suggestion.

Comment 9

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 10

[Chris Peterson [:cpeterson]]

This UX bug still exists. The meanings of the "Cancel" and "OK" buttons are confusing. Their current behavior is:

• "OK" will prevent the page from creating additional dialogs
• "Cancel" will allow the page to create additional dialogs (i.e. it "cancels the prevention").