Open Bug 692339 Opened 11 years ago Updated 2 months ago

Move startup/override page logic out of defaultArgs

Categories

(Firefox :: General, defect)

defect

Tracking

()

People

(Reporter: Margaret, Unassigned)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch wip (obsolete) — Splinter Review
This refactoring is in preparation for the changes required for the home tab, but it should make the window startup code path cleaner, and remove the need to make hacky defaultArgs checks in other parts of the browser.
Attached patch wip v2 (obsolete) — Splinter Review
This was green on try, except for jetpack tests (which I need to investigate). I want to know if there are any potential pitfalls I may be missing before I finish cleaning this up into a reviewable patch.
Attachment #565098 - Attachment is obsolete: true
Attachment #567166 - Flags: feedback?(gavin.sharp)
Attachment #567166 - Attachment is patch: true
Attached patch patchSplinter Review
I can push this to try server, but it's not too different than a previous version of the patch that was all green on try (except for jetpack tests).
Attachment #567166 - Attachment is obsolete: true
Attachment #567166 - Flags: feedback?(gavin.sharp)
Attachment #569515 - Flags: review?(gavin.sharp)
Blocks: 544819
Comment on attachment 569515 [details] [diff] [review]
patch

Clearing review, since this is going to conflict with the patch in bug 699573.
Attachment #569515 - Flags: review?(gavin.sharp)
Assignee: margaret.leibovic → nobody
See Also: → 699573
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.