Open
Bug 692339
Opened 13 years ago
Updated 2 years ago
Move startup/override page logic out of defaultArgs
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
NEW
People
(Reporter: Margaret, Unassigned)
References
Details
Attachments
(1 file, 2 obsolete files)
|
22.83 KB,
patch
|
Details | Diff | Splinter Review |
This refactoring is in preparation for the changes required for the home tab, but it should make the window startup code path cleaner, and remove the need to make hacky defaultArgs checks in other parts of the browser.
|
Reporter | |
Comment 1•13 years ago
|
||
This was green on try, except for jetpack tests (which I need to investigate). I want to know if there are any potential pitfalls I may be missing before I finish cleaning this up into a reviewable patch.
Attachment #565098 -
Attachment is obsolete: true
Attachment #567166 -
Flags: feedback?(gavin.sharp)
|
|
Reporter | |
Updated•13 years ago
|
Attachment #567166 -
Attachment is patch: true
|
|
Reporter | |
Comment 2•13 years ago
|
||
I can push this to try server, but it's not too different than a previous version of the patch that was all green on try (except for jetpack tests).
Attachment #567166 -
Attachment is obsolete: true
Attachment #567166 -
Flags: feedback?(gavin.sharp)
Attachment #569515 -
Flags: review?(gavin.sharp)
|
|
Reporter | |
Comment 3•13 years ago
|
||
Comment on attachment 569515 [details] [diff] [review]
patch
Clearing review, since this is going to conflict with the patch in bug 699573.
Attachment #569515 -
Flags: review?(gavin.sharp)
|
|
Reporter | |
Updated•13 years ago
|
Assignee: margaret.leibovic → nobody
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•