Remove support for browser.startup.page == 2 and deprecate lastPageVisited

RESOLVED FIXED in mozilla10

Status

()

Toolkit
Places
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

(Blocks: 1 bug, {addon-compat, dev-doc-complete})

Trunk
mozilla10
addon-compat, dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
I'm going to be refactoring some of our window startup code while I implement the home tab and some corresponding new startup logic, so I figured it would be a good time to clean up some of the cruft in the startup code.

This pref hasn't been accessible from the UI for a long time (I don't know when it was), and lastPageVisited is a synchronous API only used by this pref, so I think we'd be okay killing it.
I'm fine with killing the API, but just for information, are there many add-ons using it? If it ends up being needed we may want to add an asynchronous replacement.
(Assignee)

Comment 2

6 years ago
Created attachment 564373 [details] [diff] [review]
patch

As discussed on IRC, only one add-on [1] uses this API. It only supports up to 3.6a1pre, so I don't think we need to worry about breaking it.

[1] https://addons.mozilla.org/en-US/firefox/addon/firetray-10702/
Assignee: nobody → margaret.leibovic
Attachment #564373 - Flags: review?(mak77)
(Assignee)

Comment 3

6 years ago
Created attachment 564375 [details] [diff] [review]
patch

Oops, forgot to save some changes before exporting patch.
Attachment #564373 - Attachment is obsolete: true
Attachment #564373 - Flags: review?(mak77)
Attachment #564375 - Flags: review?(mak77)
Comment on attachment 564375 [details] [diff] [review]
patch

Review of attachment 564375 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. It still needs a SR for the API change before landing, gavin is already aware of this so going through him.
Attachment #564375 - Flags: superreview?(gavin.sharp)
Attachment #564375 - Flags: review?(mak77)
Attachment #564375 - Flags: review+

Updated

6 years ago
Status: NEW → ASSIGNED
Flags: in-testsuite-
Keywords: addon-compat
Attachment #564375 - Flags: superreview?(gavin.sharp) → superreview+

Updated

6 years ago
Keywords: dev-doc-needed
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/fx-team/rev/695e3b73e605
Whiteboard: [fixed-in-fx-team]
(Assignee)

Updated

6 years ago
Blocks: 692339
https://hg.mozilla.org/mozilla-central/rev/695e3b73e605
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Blocks: 692423
Docs updated:

https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIBrowserHistory

Firefox 10 for developers updated.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.