Closed
Bug 691524
Opened 13 years ago
Closed 13 years ago
Remove support for browser.startup.page == 2 and deprecate lastPageVisited
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: Margaret, Assigned: Margaret)
References
(Blocks 1 open bug)
Details
(Keywords: addon-compat, dev-doc-complete, Whiteboard: [fixed-in-fx-team])
Attachments
(1 file, 1 obsolete file)
|
6.32 KB,
patch
|
mak
:
review+
Gavin
:
superreview+
|
Details | Diff | Splinter Review |
I'm going to be refactoring some of our window startup code while I implement the home tab and some corresponding new startup logic, so I figured it would be a good time to clean up some of the cruft in the startup code. This pref hasn't been accessible from the UI for a long time (I don't know when it was), and lastPageVisited is a synchronous API only used by this pref, so I think we'd be okay killing it.
|
||
Comment 1•13 years ago
|
||
I'm fine with killing the API, but just for information, are there many add-ons using it? If it ends up being needed we may want to add an asynchronous replacement.
|
Assignee | |
Comment 2•13 years ago
|
||
As discussed on IRC, only one add-on [1] uses this API. It only supports up to 3.6a1pre, so I don't think we need to worry about breaking it. [1] https://addons.mozilla.org/en-US/firefox/addon/firetray-10702/
Assignee: nobody → margaret.leibovic
Attachment #564373 -
Flags: review?(mak77)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Oops, forgot to save some changes before exporting patch.
Attachment #564373 -
Attachment is obsolete: true
Attachment #564373 -
Flags: review?(mak77)
Attachment #564375 -
Flags: review?(mak77)
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 564375 [details] [diff] [review] patch Review of attachment 564375 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me. It still needs a SR for the API change before landing, gavin is already aware of this so going through him.
Attachment #564375 -
Flags: superreview?(gavin.sharp)
Attachment #564375 -
Flags: review?(mak77)
Attachment #564375 -
Flags: review+
|
|
||
Updated•13 years ago
|
|
||
Updated•13 years ago
|
Attachment #564375 -
Flags: superreview?(gavin.sharp) → superreview+
|
|
||
Updated•13 years ago
|
Keywords: dev-doc-needed
|
|
Assignee | |
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/695e3b73e605
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/695e3b73e605
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
|
||
Comment 7•13 years ago
|
||
Docs updated: https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIBrowserHistory Firefox 10 for developers updated.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•