The default bug view has changed. See this FAQ.

[highlighter] transitions should be disabled only while scrolling, not when the node is locked

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Developer Tools: Inspector
P3
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: paul, Assigned: paul)

Tracking

Trunk
Firefox 11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
We disable the transitions of the different highlighter elements once a node is locked. So we see these transitions only while inspecting. We don't see them when the HTML Tree view and the Breadcrumbs display are used.

So we need to disable transitions while scrolling and resizing.
I would propose that: onscroll, we disable the transitions for 200ms. If the user stops scrolling, the transitions are back. If he continues scrolling, we re-disable the transitions for 200ms, etc… (same for resizing).

Comment 1

6 years ago
is this a dupe of bug 689934?
(Assignee)

Comment 2

6 years ago
I don't think so. Bug 689934 is about the infobar's transitions not being disabled. Here I talk about when to disable transitions.
(Assignee)

Updated

6 years ago
Assignee: nobody → paul
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Blocks: 663830
(Assignee)

Comment 3

6 years ago
Also, the current behavior doesn't prevent transitions if the user is scrolling while the node is not locked.

Comment 4

6 years ago
We're doing developer tool prioritization, filter on 'brontozaur'
to ignore the spam.
Priority: -- → P3
(Assignee)

Updated

5 years ago
Whiteboard: [good first bug][mentor=paul]
(Assignee)

Updated

5 years ago
Component: Developer Tools → Developer Tools: Inspector
OS: Mac OS X → All
QA Contact: developer.tools → developer.tools.inspector
Hardware: x86 → All
(Assignee)

Comment 5

5 years ago
Created attachment 575987 [details] [diff] [review]
patch v1
(Assignee)

Updated

5 years ago
Attachment #575987 - Flags: review?(dao)
Comment on attachment 575987 [details] [diff] [review]
patch v1

Please use set/removeAttribute instead of classList.add/remove here.
Attachment #575987 - Flags: review?(dao) → review-
(In reply to Dão Gottwald [:dao] from comment #6)
> Comment on attachment 575987 [details] [diff] [review] [diff] [details] [review]
> patch v1
> 
> Please use set/removeAttribute instead of classList.add/remove here.

What's up with classList.add/remove?
(Assignee)

Comment 8

5 years ago
(In reply to Joe Walker from comment #7)
> (In reply to Dão Gottwald [:dao] from comment #6)
> > Comment on attachment 575987 [details] [diff] [review] [diff] [details] [review] [diff] [details] [review]
> > patch v1
> > 
> > Please use set/removeAttribute instead of classList.add/remove here.
> 
> What's up with classList.add/remove?

Dao meant that it's better to use an attribute than a class here.
If I'm not mistaken, classes should be re-usable.

I will use a disable-transitions attribute.
(Assignee)

Comment 9

5 years ago
Created attachment 577203 [details] [diff] [review]
patch v1.1

attribute instead of class
Attachment #575987 - Attachment is obsolete: true
Attachment #577203 - Flags: review?(dao)

Updated

5 years ago
Attachment #577203 - Flags: review?(dao) → review+
(Assignee)

Updated

5 years ago
Attachment #577203 - Flags: review?(mihai.sucan)
Comment on attachment 577203 [details] [diff] [review]
patch v1.1

Review of attachment 577203 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks and works good. Thank you!

::: browser/devtools/highlighter/inspector.jsm
@@ +699,5 @@
> +     this.IUI.win.setTimeout(function() {
> +       this.veilContainer.removeAttribute("disable-transitions");
> +       this.nodeInfo.container.removeAttribute("disable-transitions");
> +       this.transitionDisabler = null;
> +     }.bind(this), 500);

You might want to put the number in a constant at the top of the JSM.
Attachment #577203 - Flags: review?(mihai.sucan) → review+
(Assignee)

Updated

5 years ago
Whiteboard: [good first bug][mentor=paul] → [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/cc0ce6c25760
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/cc0ce6c25760
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
You need to log in before you can comment on or make changes to this bug.