Last Comment Bug 692537 - Location bar and search bar shouldn't be transparent with aero glass & tabs on top
: Location bar and search bar shouldn't be transparent with aero glass & tabs o...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All Windows 7
: -- normal (vote)
: Firefox 10
Assigned To: Dão Gottwald [:dao]
:
Mentors:
Depends on: 735607
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-06 11:47 PDT by Dão Gottwald [:dao]
Modified: 2012-03-14 02:19 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.79 KB, patch)
2011-10-06 11:47 PDT, Dão Gottwald [:dao]
shorlander: review+
Details | Diff | Review

Description Dão Gottwald [:dao] 2011-10-06 11:47:02 PDT
Created attachment 565299 [details] [diff] [review]
patch

When we started using aero glass, I made the location bar and the search bar transparent, as they were directly on glass. This mimicked the Windows Explorer look. With tabs on top and the text fields rendered on a solid background, this doesn't make as much sense. It makes the grayed out text harder to read and the bookmarks star and the history dropmarker seem to fade into the background.
Comment 1 Dão Gottwald [:dao] 2011-10-11 08:51:38 PDT
Note that this only affects aero glass. The location bar and the search bar are already opaque when using aero basic, luna, etc.
Comment 3 Marco Bonardo [::mak] 2011-10-18 05:35:40 PDT
https://hg.mozilla.org/mozilla-central/rev/4d0393ebafac
Comment 4 Siddhartha Dugar [:sdrocking] 2011-10-22 08:53:27 PDT
URL bar appears to be focused with this. Maybe I am just not used to it. Can a slightly transparent background be used?
Comment 5 Siddhartha Dugar [:sdrocking] 2011-10-22 09:14:08 PDT
The search box in the addon manager should also have a white background.

Note You need to log in before you can comment on or make changes to this bug.