692548 - Properly print OGL Shader compile errors on Android

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Girard (:BenWa)]

Simple regex fix

Comment 1

[Benoit Girard (:BenWa)]

With this patch applied I get a proper error in adb logcat:
I/Gecko   (19809): === SHADER COMPILATION FAILED ===
I/Gecko   (19809): === Source:
I/Gecko   (19809): /* sBGRATextureLayerFS */
I/Gecko   (19809): /* Fragment Shader */
I/Gecko   (19809): uniform highp int uWidth;
I/Gecko   (19809): #ifdef GL_ES
I/Gecko   (19809): precision lowp float;
I/Gecko   (19809): #endif
I/Gecko   (19809): 
I/Gecko   (19809): #ifndef NO_LAYER_OPACITY
I/Gecko   (19809): uniform float uLayerOpacity;
I/Gecko   (19809): #endif
I/Gecko   (19809): #ifdef GL_ES // for tiling, texcoord can be greater than the lowfp range
I/Gecko   (19809): varying mediump vec2 vTexCoord;
I/Gecko   (19809): #else
I/Gecko   (19809): varying vec2 vTexCoord;
I/Gecko   (19809): #endif
I/Gecko   (19809): 
I/Gecko   (19809): uniform sampler2D uTexture;
I/Gecko   (19809): void main()
I/Gecko   (19809): {
I/Gecko   (19809): gl_FragColor = texture2D(uTexture, vTexCoord).bgra * uLayerOpacity;
I/Gecko   (19809): gl_FragColor.b = fract(vTexCoord.x * uWidth);
I/Gecko   (19809): }
I/Gecko   (19809): 
I/Gecko   (19809): === Log:
I/Gecko   (19809): (22) : error C7011: implicit cast from "int" to "mediump float"
I/Gecko   (19809):

Comment 2

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 3

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be0b8f246876

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/be0b8f246876