The default bug view has changed. See this FAQ.

Properly print OGL Shader compile errors on Android

RESOLVED FIXED in mozilla10

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

Trunk
mozilla10
All
Android
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Simple regex fix
(Assignee)

Comment 1

6 years ago
With this patch applied I get a proper error in adb logcat:
I/Gecko   (19809): === SHADER COMPILATION FAILED ===
I/Gecko   (19809): === Source:
I/Gecko   (19809): /* sBGRATextureLayerFS */
I/Gecko   (19809): /* Fragment Shader */
I/Gecko   (19809): uniform highp int uWidth;
I/Gecko   (19809): #ifdef GL_ES
I/Gecko   (19809): precision lowp float;
I/Gecko   (19809): #endif
I/Gecko   (19809): 
I/Gecko   (19809): #ifndef NO_LAYER_OPACITY
I/Gecko   (19809): uniform float uLayerOpacity;
I/Gecko   (19809): #endif
I/Gecko   (19809): #ifdef GL_ES // for tiling, texcoord can be greater than the lowfp range
I/Gecko   (19809): varying mediump vec2 vTexCoord;
I/Gecko   (19809): #else
I/Gecko   (19809): varying vec2 vTexCoord;
I/Gecko   (19809): #endif
I/Gecko   (19809): 
I/Gecko   (19809): uniform sampler2D uTexture;
I/Gecko   (19809): void main()
I/Gecko   (19809): {
I/Gecko   (19809): gl_FragColor = texture2D(uTexture, vTexCoord).bgra * uLayerOpacity;
I/Gecko   (19809): gl_FragColor.b = fract(vTexCoord.x * uWidth);
I/Gecko   (19809): }
I/Gecko   (19809): 
I/Gecko   (19809): === Log:
I/Gecko   (19809): (22) : error C7011: implicit cast from "int" to "mediump float"
I/Gecko   (19809):
(Assignee)

Comment 2

6 years ago
Created attachment 565310 [details] [diff] [review]
patch
Attachment #565310 - Flags: review?(jmuizelaar)
Attachment #565310 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/be0b8f246876
(Assignee)

Updated

6 years ago
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/be0b8f246876
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
OS: Mac OS X → Android
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.