Last Comment Bug 692548 - Properly print OGL Shader compile errors on Android
: Properly print OGL Shader compile errors on Android
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All Android
: -- normal (vote)
: mozilla10
Assigned To: Benoit Girard (:BenWa)
:
:
Mentors:
Depends on:
Blocks: opengl-mobile
  Show dependency treegraph
 
Reported: 2011-10-06 12:20 PDT by Benoit Girard (:BenWa)
Modified: 2011-10-09 07:31 PDT (History)
2 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.25 KB, patch)
2011-10-06 12:23 PDT, Benoit Girard (:BenWa)
jmuizelaar: review+
Details | Diff | Splinter Review

Description Benoit Girard (:BenWa) 2011-10-06 12:20:33 PDT
Simple regex fix
Comment 1 Benoit Girard (:BenWa) 2011-10-06 12:21:16 PDT
With this patch applied I get a proper error in adb logcat:
I/Gecko   (19809): === SHADER COMPILATION FAILED ===
I/Gecko   (19809): === Source:
I/Gecko   (19809): /* sBGRATextureLayerFS */
I/Gecko   (19809): /* Fragment Shader */
I/Gecko   (19809): uniform highp int uWidth;
I/Gecko   (19809): #ifdef GL_ES
I/Gecko   (19809): precision lowp float;
I/Gecko   (19809): #endif
I/Gecko   (19809): 
I/Gecko   (19809): #ifndef NO_LAYER_OPACITY
I/Gecko   (19809): uniform float uLayerOpacity;
I/Gecko   (19809): #endif
I/Gecko   (19809): #ifdef GL_ES // for tiling, texcoord can be greater than the lowfp range
I/Gecko   (19809): varying mediump vec2 vTexCoord;
I/Gecko   (19809): #else
I/Gecko   (19809): varying vec2 vTexCoord;
I/Gecko   (19809): #endif
I/Gecko   (19809): 
I/Gecko   (19809): uniform sampler2D uTexture;
I/Gecko   (19809): void main()
I/Gecko   (19809): {
I/Gecko   (19809): gl_FragColor = texture2D(uTexture, vTexCoord).bgra * uLayerOpacity;
I/Gecko   (19809): gl_FragColor.b = fract(vTexCoord.x * uWidth);
I/Gecko   (19809): }
I/Gecko   (19809): 
I/Gecko   (19809): === Log:
I/Gecko   (19809): (22) : error C7011: implicit cast from "int" to "mediump float"
I/Gecko   (19809):
Comment 2 Benoit Girard (:BenWa) 2011-10-06 12:23:39 PDT
Created attachment 565310 [details] [diff] [review]
patch
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2011-10-09 07:31:57 PDT
https://hg.mozilla.org/mozilla-central/rev/be0b8f246876

Note You need to log in before you can comment on or make changes to this bug.