Closed
Bug 692548
Opened 14 years ago
Closed 14 years ago
Properly print OGL Shader compile errors on Android
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file)
2.25 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Simple regex fix
Assignee | ||
Comment 1•14 years ago
|
||
With this patch applied I get a proper error in adb logcat:
I/Gecko (19809): === SHADER COMPILATION FAILED ===
I/Gecko (19809): === Source:
I/Gecko (19809): /* sBGRATextureLayerFS */
I/Gecko (19809): /* Fragment Shader */
I/Gecko (19809): uniform highp int uWidth;
I/Gecko (19809): #ifdef GL_ES
I/Gecko (19809): precision lowp float;
I/Gecko (19809): #endif
I/Gecko (19809):
I/Gecko (19809): #ifndef NO_LAYER_OPACITY
I/Gecko (19809): uniform float uLayerOpacity;
I/Gecko (19809): #endif
I/Gecko (19809): #ifdef GL_ES // for tiling, texcoord can be greater than the lowfp range
I/Gecko (19809): varying mediump vec2 vTexCoord;
I/Gecko (19809): #else
I/Gecko (19809): varying vec2 vTexCoord;
I/Gecko (19809): #endif
I/Gecko (19809):
I/Gecko (19809): uniform sampler2D uTexture;
I/Gecko (19809): void main()
I/Gecko (19809): {
I/Gecko (19809): gl_FragColor = texture2D(uTexture, vTexCoord).bgra * uLayerOpacity;
I/Gecko (19809): gl_FragColor.b = fract(vTexCoord.x * uWidth);
I/Gecko (19809): }
I/Gecko (19809):
I/Gecko (19809): === Log:
I/Gecko (19809): (22) : error C7011: implicit cast from "int" to "mediump float"
I/Gecko (19809):
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #565310 -
Flags: review?(jmuizelaar)
Updated•14 years ago
|
Attachment #565310 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
OS: Mac OS X → Android
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•