692772 - Adjust alignment of sidebar with primary content when a few islands are missing

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Sai Krishna]

Attachment: screeshot

Steps:
..........

1.Load https://addons-dev.allizom.org/en-US/firefox/addon/parallel-universe/

2.Check tags section

Result: Tags in add-on detail page overlap on footer logo

Comment 1

[krupa raj[:krupa]]

This is again due to missing islands.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

This is due to the fix for bug 687740: https://github.com/jbalogh/zamboni/commit/6a738b7
Potch, how do you feel about using `display: table`?

Comment 3

[Wil Clouser [:clouserw]]

I just gave another island bug to potch, so -> potch for this one too.  Sry if you're already working on it, cvan.

Comment 4

[Potch [:potch]]

> Potch, how do you feel about using `display: table`?

I'm actually totally down with it. Our issue is that we don't have consistent rows- the big problems here are missing islands on the left. We may have to revisit some of this island pairing business (and by may I mean we probably should because things are getting janky.)

Comment 5

[Potch [:potch]]

CCing greg on this. cvan, he, and I should have a meetings of the minds about islands and how we can do them better.

AMO Frontends Assemble!

Comment 6

[Christopher Van Wiemeersch [:cvan]]

`display: table` let's do it.

Comment 7

[krupa raj[:krupa]]

This also causes a lot of overlap of sections at https://addons-dev.allizom.org/en-US/firefox/addon/nsinavhistoryobserver-mobil/

Comment 8

[Christopher Van Wiemeersch [:cvan]]

https://github.com/jbalogh/zamboni/commit/286fd9d

Comment 9

[Pratibha]

Attachment: screenshot

verified at:
https://addons-dev.allizom.org/en-US/firefox/addon/parallel-universe/