Closed
Bug 692894
Opened 13 years ago
Closed 12 years ago
update Sidebar.js implementation to match interface changes from bug 691647
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.32 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Bug 691647's patch removes methods from the nsISidebar interface, so Fennec's implementation needs to be updated accordingly.
|
Assignee | |
Comment 1•13 years ago
|
||
This is pretty simple, since these weren't supported anyways!
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #565610 -
Flags: review?(mark.finkle)
|
||
Comment 2•13 years ago
|
||
Has to be the wrong patch :)
|
|
Assignee | |
Comment 3•13 years ago
|
||
That was the wrong patch!
Attachment #565610 -
Attachment is obsolete: true
Attachment #565610 -
Flags: review?(mark.finkle)
Attachment #565620 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Oh, I can leave the "nsISidebar" comment.
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 565620 [details] [diff] [review]
patch
r+ with keeping the comment
Attachment #565620 -
Flags: review?(mark.finkle) → review+
|
||
Comment 6•12 years ago
|
||
This patch will need to be unbitrotted.
I think we talked about this on IRC before... can we just get rid of this whole file, since we don't have a sidebar?
Product: Fennec Graveyard → Firefox for Android
|
|
Assignee | |
Comment 7•12 years ago
|
||
No - the interface actually has nothing to do with sidebars, it's just where the OpenSearch APIs live (specced in HTML5 as methods on window.external, but we also support variants on window.sidebar). What we can do is get rid of the non-standard window.sidebar variants at some point, but I think we should track that separately (and might be best to wait until after bug 518929/bug 530847 anyways).
|
|
||
Comment 8•12 years ago
|
||
|
||
Comment 9•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•