Closed
Bug 518929
Opened 15 years ago
Closed 10 years ago
implement window.external APIs in core code
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: Gavin, Assigned: mossop)
References
Details
Attachments
(1 file, 1 obsolete file)
|
30.41 KB,
patch
|
Details | Diff | Splinter Review |
They're really part of the web platform at this point, and shouldn't need to be re-implemented in Gecko consumers (i.e. Fennec and Firefox).
They'd also benefit from being tied to windows to avoid having to fix bug 334875 (and all of its dependencies).
They depend on the search service, but that's in toolkit now, and we can just have the methods throw if the service isn't present.
|
Reporter | |
Comment 1•15 years ago
|
||
Not fully implemented yet, but stubs out the object in nsGlobalWindow. Modeled this on the existing nsNavigator/nsLocation stuff, but there are some details that I'm not sure about (related to WindowStateHolder, and what should happen in nsGlobalWindow::SetNewDocument - we "update mNavigator's docshell pointer now", but don't for mLocation for some reason).
|
|
Reporter | |
Comment 2•15 years ago
|
||
nsISidebar is a really crappy interface (uses string/wstring, doesn't specify support for relative URIs, etc). I think we should probably just fix it, since I don't think there are internal (or native code) callers.
|
|
Reporter | |
Comment 3•14 years ago
|
||
Attachment #404564 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 4•12 years ago
|
||
I'd like to drop support for window.sidebar (bug 862147), so re-summarizing.
No longer blocks: 341283
Summary: implement search nsSidebar APIs (window.sidebar.addSearchEngine, window.external.AddSearchProvider) in core code → implement window.external APIs in core code
|
Assignee | |
Comment 5•10 years ago
|
||
Fixed by bug 1068186
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•