The default bug view has changed. See this FAQ.

Improve poor man's Maybe<AutoCompartment> in JSAutoEnterCompartment.

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Unassigned)

Tracking

unspecified
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [iOS])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
We currently size the storage inside JSAutoEnterCompartment based on a platform-specific guess.  This broke ted's iOS port, and it's ugly.

We may be able to rely on the fact (?) that 32-bit systems with alignof(uint64) == 4 have 13-word AutoCompartments, while 32-bit systems with alignof(uint64) == 8 have 16-word AutoCompartments.
(Reporter)

Comment 1

6 years ago
Created attachment 565995 [details] [diff] [review]
Patch v1
(Reporter)

Comment 2

6 years ago
Comment on attachment 565995 [details] [diff] [review]
Patch v1

I think this works.
Attachment #565995 - Flags: review?(luke)

Updated

6 years ago
Attachment #565995 - Flags: review?(luke) → review+
(Reporter)

Updated

6 years ago
Depends on: 691192
(Reporter)

Comment 3

6 years ago
Thanks, Luke.

https://hg.mozilla.org/integration/mozilla-inbound/rev/962683b9d15a
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/962683b9d15a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Whiteboard: [inbound] → [inbound][iOS]
(Reporter)

Updated

6 years ago
Whiteboard: [inbound][iOS] → [iOS]

Updated

6 years ago
Duplicate of this bug: 693585
Just for interest in case this dings other arches, on PPC this turned out to be 15 bytes, for some reason.
s/bytes/words/
You need to log in before you can comment on or make changes to this bug.