Closed Bug 693691 Opened 11 years ago Closed 11 years ago

Only list free webapps/add-ons in the dropdown box for upsell settings

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: krupa.mozbugs, Assigned: andy+bugzilla)

References

()

Details

(Whiteboard: [webapps])

Attachments

(1 file)

steps to reproduce:
1. Load https://addons-dev.allizom.org/en-US/developers/addon/app-337450/payments/3
2. Notice the options available in the dropdown menu.

expected behavior:
Only free webapps are listed.

actual behavior:
paid webapps and add-ons are listed.
Can't reproduce yet, locally on -dev and in tests only free addons are shown.
Assignee: nobody → amckay
I see this http://screencast.com/t/Nmkp8FuaSh.

Andy, do you have disabled add-ons/paid webapps associated with the same account?
Priority: -- → P4
I can link mark an add-on as upsell to an app which seems wrong.
Summary: Only list free webapps in the dropdown box for upsell settings → Only list free webapps/add-ons in the dropdown box for upsell settings
Is this a dupe of bug 679824?
Nope. This bug is about free apps and add-ons-> We shouldn't be listing premium or disabled add-ons/apps in upsell dropdown. The other bug is about not listing add-ons with contributions.
Note https://apps-preview-dev.allizom.org/en-US/apps/app/goofy/?src=cb-dl-home is marked as upsell for "DuckSauce" when both are premium apps. This seems bad. Is this bug still P4?
Attached image screenshot
(In reply to krupa raj 82[:krupa] from comment #6)
> Note
> https://apps-preview-dev.allizom.org/en-US/apps/app/goofy/?src=cb-dl-home is
> marked as upsell for "DuckSauce" when both are premium apps. This seems bad.
> Is this bug still P4?

If no one else can reproduce it, yeah.
Blocks: 710074
No longer blocks: 690899
The only way I can reproduce this is by making an addon the target of an upsell and then making that addon premium. Will stop this.
https://github.com/mozilla/zamboni/commit/9b8365
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.