693713 - Welcome banners on webapps pages

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons-dev.allizom.org/en-US/apps/app/test-webapp-2/ in a non-Firefox browser.
2. Notice the banner- 'To try the thousands of add-ons available here, download Mozilla Firefox, a fast, free way to surf the Web!'

expected behavior:
Apps don't require Firefox to work. There are no welcome banners for webapps

actual behavior:
Webapps have banners with content relating to add-ons.

Comment 1

[krupa raj[:krupa]]

https://apps-preview-dev.allizom.org/en-US/firefox/users/login still shows the welcome banner. See screenshot.

Comment 2

[krupa raj[:krupa]]

Attachment: screenshot for reopen

Comment 3

[Davor Spasovski [:spasovski]]

Thanks Potch!

Comment 4

[Potch [:potch]]

Is the appropriate solution here to remove the balloon? We'll be mixing all this content soon enough.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Don't forget to remove/comment out the qunit tests too.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

(yes)

Comment 7

[Potch [:potch]]

https://github.com/mozilla/zamboni/commit/df9b2ec

Comment 8

[krupa raj[:krupa]]

The banner is still seen on loading the page in a non-FF browser. Reopening.

Comment 9

[Potch [:potch]]

Is this still an issue?

Comment 10

[Potch [:potch]]

Pretty sure this is fixed.

Comment 11

[krupa raj[:krupa]]

This is not fixed on mobile pages. Try opening the app-preview-dev in mobile native browser.

Comment 12

[Potch [:potch]]

This is fixed, as far as I can tell. Please list a URL if reopening.

Comment 13

[Cristian Boldan]

Verified as fixed in https://apps-preview-dev.allizom.org/en-US/firefox/users/login
Attaching postfix screenshot.
Closing bug.

Comment 14

[Cristian Boldan]

Attachment: postfix apps header