693897 - Allow addons to opt-in to strict compatibility checking

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

With addons defaulting to compatible, addons need a way to opt-in to having the Addons Manager enforce strict compatibility checks - so the addon is only marked as compatible if it explicitly matches the addon's targetApplications compatibility data. This would be via a new field in install.rdf, named "strictCompatibility" (or something similar).

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/1fb831781a15

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Test addon - strict compatibility opt-in

Here's a test addon that demonstrates the strictCompatibility option in install.rdf. It's compatible version range is Firefox 7.0 to 8.0. So it should *always* be marked as incompatible.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Test addon - strict compatibility no opt-in

Another test addon - this has the strictCompatibility option, but it's set to false. So it should behave like any other addon that didn't have that option in isn't install.rdf.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/41c52a9e1337

Comment 6

[Jean-Yves Perrier [:teoli]]

I updated:
https://developer.mozilla.org/en/Install_Manifests#strictCompatibility
https://developer.mozilla.org/en/Building_an_Extension#section_4
and
https://developer.mozilla.org/en/Firefox_10_for_developers

Comment 7

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux x86_64; rv:11.0a1) Gecko/20111121 Firefox/11.0a1
Mozilla/5.0 (X11; Linux x86_64; rv:10.0a2) Gecko/20111121 Firefox/10.0a2

Verified on Ubuntu 11.10, Mac OS 10.7, Windows XP and Windows 7 using the examples add-ons provided in the attachment and adding the string to existing add-ons in install.rdf.

1. Start Firefox 7 or 8 with a clean profile. (if upgrading to F10 set the extensions.strictCompatible pref to true)
2. Install an add-on with strictCompatibility set to true and an add-on with the pref set to false in install.rdf
3. Manually upgrade to Firefox 10/11.

When <em:strictCompatibility> is set to true, the add-on is listed as incompatible even with extensions.strictCompatibility enabled.
When <em:strictCompatibility> is set to false, the add-on is listed as compatible with extensions.strictCompatibility enabled.