Last Comment Bug 693996 - Errors when switching scripts in the debugger
: Errors when switching scripts in the debugger
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Panos Astithas [:past]
:
: J. Ryan Stinnett [:jryans] (use ni?)
Mentors:
Depends on:
Blocks: minotaur
  Show dependency treegraph
 
Reported: 2011-10-12 07:07 PDT by Panos Astithas [:past]
Modified: 2011-10-21 09:12 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Working patch (1.83 KB, patch)
2011-10-12 08:29 PDT, Panos Astithas [:past]
dcamp: review-
Details | Diff | Splinter Review
Working patch v2 (7.02 KB, patch)
2011-10-18 08:49 PDT, Panos Astithas [:past]
dcamp: review+
Details | Diff | Splinter Review

Description Panos Astithas [:past] 2011-10-12 07:07:36 PDT
Switching the displayed script in the editor does not seem to work currently:

JavaScript error: chrome://browser/content/debugger/debugger.js, line 328: aScript is null

This is a regression.
Comment 1 Panos Astithas [:past] 2011-10-12 08:29:06 PDT
Created attachment 566540 [details] [diff] [review]
Working patch

Got it. It was a typo and a property vs. attribute issue. Plus a tiny fix for caching the script contents.
Comment 2 Dave Camp (:dcamp) 2011-10-17 10:20:52 PDT
Comment on attachment 566540 [details] [diff] [review]
Working patch

We should have test coverage for switching sources, r-'ing for that.
Comment 3 Panos Astithas [:past] 2011-10-18 08:49:33 PDT
Created attachment 567762 [details] [diff] [review]
Working patch v2

Added tests for changing the selected script in both paused and running states.

Note You need to log in before you can comment on or make changes to this bug.