The default bug view has changed. See this FAQ.

Errors when switching scripts in the debugger

RESOLVED FIXED

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: past, Assigned: past)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Switching the displayed script in the editor does not seem to work currently:

JavaScript error: chrome://browser/content/debugger/debugger.js, line 328: aScript is null

This is a regression.
Assignee: nobody → past
Status: NEW → ASSIGNED
Created attachment 566540 [details] [diff] [review]
Working patch

Got it. It was a typo and a property vs. attribute issue. Plus a tiny fix for caching the script contents.
Attachment #566540 - Flags: review?(dcamp)

Comment 2

6 years ago
Comment on attachment 566540 [details] [diff] [review]
Working patch

We should have test coverage for switching sources, r-'ing for that.
Attachment #566540 - Flags: review?(dcamp) → review-
Created attachment 567762 [details] [diff] [review]
Working patch v2

Added tests for changing the selected script in both paused and running states.
Attachment #566540 - Attachment is obsolete: true
Attachment #567762 - Flags: review?(dcamp)

Updated

6 years ago
Attachment #567762 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/38c048a9a8ec
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.