694319 - Email Address label is not correctly aligned to text field in /es-ES page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Description

[Pratibha]

Attachment: screenshot

Steps:
=======
-Log in at: https://addons-dev.allizom.org/es-ES/firefox/users/edit
compare to:
https://addons-dev.allizom.org/en-US/firefox/users/edit

Result: spanish translated label for "Email Address" is not aligned properly to the text field

Comment 1

[Mark Striemer [:mstriemer]]

This isn't specific to the Spanish page, it will happen any time there is a long label. The * breaking to the next line can be fixed by using ` ` instead of a regular space but this occurs in several other places. Adjusting the vertical-align makes it look a bit nicer. I'm not sure if we want these changes applied globally so I only applied it to the user edit form. It is definitely also an issue on the register form but there can definitely be more occurrences (just make a translation longer or edit in browser).

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Updated label

Updated label with non-breaking space before the * and updated vertical-align.

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: Basic stacked form

cvan suggested that the forms would work better if the labels and inputs were stacked. Here's what it would like like if we did that.

Comment 4

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/commit/ac23cc464b6fa1b9649ca8f9462f679dc2254ff3

Comment 5

[Iulian Timis]

Verified as fixed in https://addons-dev.allizom.org/es/firefox/users/edit in FF26 (Win 7).
Attaching postfix screenshot.
Closing bug.

Comment 6

[Iulian Timis]

Attachment: postfix_email_field.png