Closed Bug 694595 Opened 12 years ago Closed 12 years ago

Some settings for add-ons aren't being migrated when we change database schemas

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Version:
8 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla10
Tracking Flags:
Tracking Status
firefox8 --- fixed
firefox9 --- fixed

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Keywords: dataloss, Whiteboard: [qa+])

Attachments

(1 file)

patch rev 1
16.72 KB, patch
Unfocused
: review+
christian
: approval-mozilla-aurora+
christian
: approval-mozilla-beta+
Details | Diff | Splinter Review 
applyBackgroundUpdates, sourceURI and resourceURI are getting lost whenever we update the DB schema
Attached patch patch rev 1 — — Splinter Review 
Add migration for these fields and a test for it.
Attachment #567776 - Flags: review?(bmcbride)
Comment on attachment 567776 [details] [diff] [review]
patch rev 1

Review of attachment 567776 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

(Oh hell, I'm bitrotten already)
Attachment #567776 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/mozilla-central/rev/2739199a5bbd
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Keywords: dataloss
Comment on attachment 567776 [details] [diff] [review]
patch rev 1

Bug 693743 does a schema change which will cause this set of dataloss to happen again so I'd very much like to take this patch as well (also the patch in bug 693743 will have to be changed without it), it is low risk enough that I think it's ok to take on beta.
Attachment #567776 - Flags: approval-mozilla-beta?
Attachment #567776 - Flags: approval-mozilla-aurora?
---------------------------------[ Triage Comment ]---------------------------------

Approving for 8beta and 9aurora as this is a dataloss bug that will be triggered again by bug 693743. The patch looks to be low risk and contained.

Please land ASAP.
Attachment #567776 - Flags: approval-mozilla-beta?
Attachment #567776 - Flags: approval-mozilla-beta+
Attachment #567776 - Flags: approval-mozilla-aurora?
Attachment #567776 - Flags: approval-mozilla-aurora+
Target Milestone: --- → mozilla10
Are there any specific instructions for QA to verify this fix?
Whiteboard: [qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #8)
> Are there any specific instructions for QA to verify this fix?

Run Firefox 7 and install an add-on, in its details change its auto-update setting to something other than default. Update to Firefox 8 and check that that setting is retained.
Whiteboard: [qa?] → [qa+]
I've verified this on Win 7 32 and 64 updating Firefox 7.0.1 with Adblock Plus 1.3.10 to Firefox 8.0.1. The addon was initially set with automatic updates ON, but after the update has changed to OFF. If automatic updates is set to default or OFF, the setting remains the same after the update.
I take it this bug can be marked VERIFIED then? Paul, Dave, please confirm.
No, it is not the right scenario. Dave?
(In reply to Paul Silaghi [QA] from comment #12)
> No, it is not the right scenario. Dave?

No this is not correct, please file a new bug with specific STR
New bug 705631 logged. Can I mark this as verified fixed now ?
Depends on: 705631
Dave, can this be marked verified fixed based on Paul's testing? Is there something else we can do? Should this be retested given the dependency being fixed?
Whiteboard: [qa+] → [qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #15)
> Dave, can this be marked verified fixed based on Paul's testing? Is there
> something else we can do? Should this be retested given the dependency being
> fixed?

I would re-test with the fix from the other bug too and then verify.
Whiteboard: [qa?] → [qa+]
Fix for bug #705631 was pushed only for m-c and cannot be verified in beta.
Dave, will the fix for bug 705631 ever make it into Firefox 9? If not, I don't think we will be able to retest this as requested in comment 16.
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #18)
> Dave, will the fix for bug 705631 ever make it into Firefox 9? If not, I
> don't think we will be able to retest this as requested in comment 16.

You can re-test with trunk though right? I'm not sure it's worth trying to push the fix for this down to beta.
Well we can, Dave. Though this bug was fixed on Firefox 8 and 9 -- that's where we are trying to verify the fix. Testing on trunk is fine for bug 705631, but I don't see how that enables us to mark this bug VERIFIED for 8 and 9.
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #20)
> Well we can, Dave. Though this bug was fixed on Firefox 8 and 9 -- that's
> where we are trying to verify the fix. Testing on trunk is fine for bug
> 705631, but I don't see how that enables us to mark this bug VERIFIED for 8
> and 9.

Well I guess the point is that it isn't fully fixed for 8 and 9.
Since we already verified this once, I'm thinking we can mark this VERIFIED and we can retest it on bug 705631 if/when it gets ported to Aurora/Beta. Does this sound reasonable?
I verified the fix of bug #705631 on Nightly and it worked as expected.
You need to log in before you can comment on or make changes to this bug.