VC11 fails to compile angle because pool_allocator<T> doesn't have operator =

RESOLVED FIXED in mozilla10

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla10
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
I dont have VC11 at the moment so I can hardly make a patch, but if you do make a patch I'll drive it in ANGLE upstream.
Created attachment 567310 [details] [diff] [review]
Patch (v1)

I had to convert the reference member to a pointer in order to be able to assign to it inside operator=.

I will look into upstreaming this fix.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #567310 - Flags: review?(bjacob)
Duplicate of this bug: 687268
Blocks: 687213
Comment on attachment 567310 [details] [diff] [review]
Patch (v1)

Review of attachment 567310 [details] [diff] [review]:
-----------------------------------------------------------------

Just add a mention of the ANGLE revision number in README.mozilla.
Attachment #567310 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cd13969b61e
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/1cd13969b61e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Depends on: 709369
You need to log in before you can comment on or make changes to this bug.