[highlighter] [infobar] If a node is not visible anymore, the infobar should point to the direction of the node
RESOLVED
FIXED
in Firefox 12
Status
People
(Reporter: paul, Assigned: paul)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: [good first bug][mentor=paul][lang=js][lang=css])
Attachments
(2 attachments, 1 obsolete attachment)
|
1.80 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
|
4.96 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
The current behavior is to move the infobar to the top-right corner. It would make more sense to keep the infobar aligned with the node, and make it point to its direction.
|
(Assignee) | |
Updated•7 years ago
|
Whiteboard: [[good first bug][mentor=paul]
|
|
(Assignee) | |
Updated•7 years ago
|
Whiteboard: [[good first bug][mentor=paul] → [good first bug][mentor=paul][lang=js/css]
|
|
(Assignee) | |
Updated•7 years ago
|
Whiteboard: [good first bug][mentor=paul][lang=js/css] → [good first bug][mentor=paul][lang=js][lang=css]
|
|
(Assignee) | |
Comment 1•7 years ago
|
||
Created attachment 579696 [details] [diff] [review] patch v1
|
|
(Assignee) | |
Updated•7 years ago
|
Attachment #579696 -
Flags: review?(rcampbell)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 579696 [details] [diff] [review] patch v1 I see what you did there. Is this something we need a test for?
Attachment #579696 -
Flags: review?(rcampbell) → review+
|
||
Comment 3•7 years ago
|
||
Assigning this to Paul as it appears that he is working on this. I'm trying to keep the status of our mentored bugs up to date. Please unassign if this was done in error.
Assignee: nobody → paul
Status: NEW → ASSIGNED
|
|
(Assignee) | |
Comment 4•7 years ago
|
||
Created attachment 582834 [details] [diff] [review] patch v1.1 with test
|
|
(Assignee) | |
Updated•7 years ago
|
Attachment #582834 -
Flags: review?(rcampbell)
|
|
||
Updated•7 years ago
|
Attachment #582834 -
Flags: review?(rcampbell) → review+
|
|
||
Comment 5•7 years ago
|
||
- let rect = this._highlightRect;
- if (rect && this._highlighting) {
+ if (this._highlightRect) {
let winHeight = this.win.innerHeight * this.zoom;
let winWidth = this.win.innerWidth * this.zoom;
+
+ let rect = {top: this._highlightRect.top,
+ left: this._highlightRect.left,
+ width: this._highlightRect.width,
+ height: this._highlightRect.height};
this didn't apply cleanly. Wondering if you had some other patch installed previously, as the let winHeight = … and winWidth lines were not there.
Added them.|
|
||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8a9d9d0d3897
Whiteboard: [good first bug][mentor=paul][lang=js][lang=css] → [good first bug][mentor=paul][lang=js][lang=css][fixed-in-fx-team]
|
||
Comment 7•7 years ago
|
||
Backed out because of orange https://hg.mozilla.org/integration/fx-team/rev/37b413b9c87b
Whiteboard: [good first bug][mentor=paul][lang=js][lang=css][fixed-in-fx-team] → [good first bug][mentor=paul][lang=js][lang=css]
|
||
Updated•7 years ago
|
Target Milestone: --- → Firefox 12
|
|
(Assignee) | |
Comment 8•7 years ago
|
||
Created attachment 583479 [details] [diff] [review] patch 2 So this should fix the test issue. https://tbpl.mozilla.org/?tree=Try&rev=9e5579f7bb5e
|
|
(Assignee) | |
Updated•7 years ago
|
Attachment #582834 -
Attachment is obsolete: true
|
|
(Assignee) | |
Comment 9•7 years ago
|
||
Apparently, this is working.
|
|
(Assignee) | |
Updated•7 years ago
|
Attachment #583479 -
Flags: review?(rcampbell)
|
|
||
Comment 10•7 years ago
|
||
Comment on attachment 583479 [details] [diff] [review] patch 2 alright, let's try this again. :)
Attachment #583479 -
Flags: review?(rcampbell) → review+
|
|
||
Updated•7 years ago
|
Whiteboard: [good first bug][mentor=paul][lang=js][lang=css] → [good first bug][mentor=paul][lang=js][lang=css][land-in-fx-team]
|
|
||
Comment 11•7 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/bb8833c7cbf9
Whiteboard: [good first bug][mentor=paul][lang=js][lang=css][land-in-fx-team] → [good first bug][mentor=paul][lang=js][lang=css][fixed-in-fx-team]
|
|
||
Comment 12•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bb8833c7cbf9
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=paul][lang=js][lang=css][fixed-in-fx-team] → [good first bug][mentor=paul][lang=js][lang=css]
|
||
Updated•9 months ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•