Closed Bug 694954 Opened 9 years ago Closed 9 years ago

[highlighter] [infobar] If a node is not visible anymore, the infobar should point to the direction of the node

Categories

(DevTools :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 12

People

(Reporter: paul, Assigned: paul)

References

Details

(Whiteboard: [good first bug][mentor=paul][lang=js][lang=css])

Attachments

(2 files, 1 obsolete file)

The current behavior is to move the infobar to the top-right corner. It would make more sense to keep the infobar aligned with the node, and make it point to its direction.
Blocks: 663830
Whiteboard: [[good first bug][mentor=paul]
Whiteboard: [[good first bug][mentor=paul] → [good first bug][mentor=paul][lang=js/css]
Whiteboard: [good first bug][mentor=paul][lang=js/css] → [good first bug][mentor=paul][lang=js][lang=css]
Depends on: 689939
Attached patch patch v1Splinter Review
Attachment #579696 - Flags: review?(rcampbell)
Comment on attachment 579696 [details] [diff] [review]
patch v1

I see what you did there.

Is this something we need a test for?
Attachment #579696 - Flags: review?(rcampbell) → review+
Assigning this to Paul as it appears that he is working on this. 

I'm trying to keep the status of our mentored bugs up to date. Please unassign if this was done in error.
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attached patch patch v1.1 (obsolete) — Splinter Review
with test
Attachment #582834 - Flags: review?(rcampbell)
Attachment #582834 - Flags: review?(rcampbell) → review+
-    let rect = this._highlightRect;
-    if (rect && this._highlighting) {
+    if (this._highlightRect) {
       let winHeight = this.win.innerHeight * this.zoom;
       let winWidth = this.win.innerWidth * this.zoom;
+
+      let rect = {top: this._highlightRect.top,
+                  left: this._highlightRect.left,
+                  width: this._highlightRect.width,
+                  height: this._highlightRect.height};

this didn't apply cleanly. Wondering if you had some other patch installed previously, as the let winHeight = … and winWidth lines were not there.

Added them.
https://hg.mozilla.org/integration/fx-team/rev/8a9d9d0d3897
Whiteboard: [good first bug][mentor=paul][lang=js][lang=css] → [good first bug][mentor=paul][lang=js][lang=css][fixed-in-fx-team]
Backed out because of orange

https://hg.mozilla.org/integration/fx-team/rev/37b413b9c87b
Whiteboard: [good first bug][mentor=paul][lang=js][lang=css][fixed-in-fx-team] → [good first bug][mentor=paul][lang=js][lang=css]
Target Milestone: --- → Firefox 12
Attached patch patch 2Splinter Review
So this should fix the test issue.
https://tbpl.mozilla.org/?tree=Try&rev=9e5579f7bb5e
Attachment #582834 - Attachment is obsolete: true
Apparently, this is working.
Attachment #583479 - Flags: review?(rcampbell)
Comment on attachment 583479 [details] [diff] [review]
patch 2

alright, let's try this again. :)
Attachment #583479 - Flags: review?(rcampbell) → review+
Whiteboard: [good first bug][mentor=paul][lang=js][lang=css] → [good first bug][mentor=paul][lang=js][lang=css][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/bb8833c7cbf9
Whiteboard: [good first bug][mentor=paul][lang=js][lang=css][land-in-fx-team] → [good first bug][mentor=paul][lang=js][lang=css][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/bb8833c7cbf9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=paul][lang=js][lang=css][fixed-in-fx-team] → [good first bug][mentor=paul][lang=js][lang=css]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.