694954 - [highlighter] [infobar] If a node is not visible anymore, the infobar should point to the direction of the node

Status: RESOLVED FIXED

Description

[Paul Rouget [:paul]]

The current behavior is to move the infobar to the top-right corner. It would make more sense to keep the infobar aligned with the node, and make it point to its direction.

Comment 1

[Paul Rouget [:paul]]

Created attachment 579696 [details] [diff] [review]
patch v1

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 579696 [details] [diff] [review]
patch v1

I see what you did there.

Is this something we need a test for?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Assigning this to Paul as it appears that he is working on this. 

I'm trying to keep the status of our mentored bugs up to date. Please unassign if this was done in error.

Comment 4

[Paul Rouget [:paul]]

Created attachment 582834 [details] [diff] [review]
patch v1.1

with test

Comment 5

[Rob Campbell [:rc] (:robcee)]

-    let rect = this._highlightRect;
-    if (rect && this._highlighting) {
+    if (this._highlightRect) {
       let winHeight = this.win.innerHeight * this.zoom;
       let winWidth = this.win.innerWidth * this.zoom;
+
+      let rect = {top: this._highlightRect.top,
+                  left: this._highlightRect.left,
+                  width: this._highlightRect.width,
+                  height: this._highlightRect.height};

this didn't apply cleanly. Wondering if you had some other patch installed previously, as the let winHeight = … and winWidth lines were not there.

Added them.

Comment 6

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/8a9d9d0d3897

Comment 7

[Tim Taubert [:ttaubert] (on PTO, back Aug 28th)]

Backed out because of orange

https://hg.mozilla.org/integration/fx-team/rev/37b413b9c87b

Comment 8

[Paul Rouget [:paul]]

Created attachment 583479 [details] [diff] [review]
patch 2

So this should fix the test issue.
https://tbpl.mozilla.org/?tree=Try&rev=9e5579f7bb5e

Comment 9

[Paul Rouget [:paul]]

Apparently, this is working.

Comment 10

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 583479 [details] [diff] [review]
patch 2

alright, let's try this again. :)

Comment 11

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/bb8833c7cbf9

Comment 12

[Tim Taubert [:ttaubert] (on PTO, back Aug 28th)]

https://hg.mozilla.org/mozilla-central/rev/bb8833c7cbf9