Vorbis playback is broken on Android

RESOLVED FIXED in mozilla10

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

({regression})

Trunk
mozilla10
ARM
Android
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
While debugging Android audio problems, my test file plays back with corrupt/invalid audio samples after updating my tree.  Bisecting the breakage revealed that bug 677581 regressed playback of Vorbis on Android.
(Assignee)

Updated

6 years ago
Blocks: 677581
(Assignee)

Comment 1

6 years ago
Created attachment 567644 [details] [diff] [review]
patch v0

Tim pointed out that the new config_types.h had an incorrect definition of ogg_int64_t.  I've confirmed that fixing that solves the regression.
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Attachment #567644 - Flags: review?(tterribe)
Attachment #567644 - Flags: review?(tterribe) → review+
Comment on attachment 567644 [details] [diff] [review]
patch v0

This should be fine. long long will be 64 bits on both 32 and 64 bit systems.

Sorry for the breakage; this checked-in-config-types thing is a real hack.
Attachment #567644 - Flags: review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/9fd182788cd7
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/9fd182788cd7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.