Last Comment Bug 695240 - Vorbis playback is broken on Android
: Vorbis playback is broken on Android
Status: RESOLVED FIXED
: regression
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: ARM Android
: -- normal (vote)
: mozilla10
Assigned To: Matthew Gregan [:kinetik]
:
: Maire Reavy [:mreavy]
Mentors:
http://flim.org/~kinetik/sync_a.webm
Depends on:
Blocks: 677581
  Show dependency treegraph
 
Reported: 2011-10-17 17:27 PDT by Matthew Gregan [:kinetik]
Modified: 2011-10-20 03:10 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v0 (465 bytes, patch)
2011-10-17 18:19 PDT, Matthew Gregan [:kinetik]
tterribe: review+
giles: review+
Details | Diff | Splinter Review

Description Matthew Gregan [:kinetik] 2011-10-17 17:27:51 PDT
While debugging Android audio problems, my test file plays back with corrupt/invalid audio samples after updating my tree.  Bisecting the breakage revealed that bug 677581 regressed playback of Vorbis on Android.
Comment 1 Matthew Gregan [:kinetik] 2011-10-17 18:19:13 PDT
Created attachment 567644 [details] [diff] [review]
patch v0

Tim pointed out that the new config_types.h had an incorrect definition of ogg_int64_t.  I've confirmed that fixing that solves the regression.
Comment 2 Ralph Giles (:rillian) needinfo me 2011-10-18 17:11:39 PDT
Comment on attachment 567644 [details] [diff] [review]
patch v0

This should be fine. long long will be 64 bits on both 32 and 64 bit systems.

Sorry for the breakage; this checked-in-config-types thing is a real hack.
Comment 3 Matthew Gregan [:kinetik] 2011-10-19 15:53:02 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/9fd182788cd7
Comment 4 Marco Bonardo [::mak] 2011-10-20 03:10:08 PDT
https://hg.mozilla.org/mozilla-central/rev/9fd182788cd7

Note You need to log in before you can comment on or make changes to this bug.