Closed Bug 695256 Opened 10 years ago Closed 10 years ago
Switch from PRBool to bool and replace PR
_TRUE/PR _FALSE with true/false in comm-central
q.v. Mozilla Central bugs: Bug 690892 - replace PR_TRUE/PR_FALSE with true/false in mozilla-central. Bug 675553 - Switch from PRBool to bool on a CLOSED TREE.
I think considering this is just a script run against the repo, we should just do all of comm-central in one changeset and be done with it.
Component: General → Backend
Product: SeaMonkey → MailNews Core
QA Contact: general → backend
Summary: Switch from PRBool to bool and replace PR_TRUE/PR_FALSE with true/false in Suite → Switch from PRBool to bool and replace PR_TRUE/PR_FALSE with true/false in comm-central
(In reply to Mark Banner (:standard8) from comment #1) > I think considering this is just a script run against the repo, we should > just do all of comm-central in one changeset and be done with it. Sounds Good. You can do this if you like, with post-landing review from me if you want. And promise to spot-check first :-) (so hopefully we don't have in-tree-bustage) (I just want to wait until the SeaMonkey buildbot master comes back up before landing it)
Well, I'd at least expect a run through try server first.
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
I think whilst we're in this natural quiet period we should just get this done - afaik no big patches are pending, and they can always be patched - see the scripts on the dependent bugs. These scripts are for OS X, replace <script> in this attachment with the name of the sed script from either of the other attachments. I've pushed this to try as: http://hg.mozilla.org/try-comm-central/rev/c60b80c3f05e http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=c60b80c3f05e If the builds are successful and pass tests, I'm proposing to push this to comm-central as soon as I can - I'll do a post to the newsgroups as well.
Attachment #584790 - Flags: review?(dbienvenu)
Attachment #584783 - Attachment is patch: false
In reply to comment #6: IIUC, this covers Thunderbird and MailNews Core. What about SeaMonkey code not shared with Fx & Tb? - this bug or another bug? - covered yes/no by the sed scripts? - covered yes/no by the try builds? - tested yes/no after building?
Comment on attachment 584790 [details] find & sed script for replacements I think this is just the find script, but it looks OK.
Attachment #584790 - Flags: review?(dbienvenu) → review+
(In reply to David :Bienvenu from comment #8) > I think this is just the find script, but it looks OK. Yes, see the other two attachments (sorry, I wasn't caring too much about individual reviews on each). (In reply to Tony Mechelynck [:tonymec] from comment #7) > In reply to comment #6: > IIUC, this covers Thunderbird and MailNews Core. What about SeaMonkey code > not shared with Fx & Tb? This covers all of comm-central code apart from ldap/sdks/c-sdk which is imported from an external location, and would be up to the maintainers to change if they wanted to.
I landed this earlier today, everything seems fine still: http://hg.mozilla.org/comm-central/rev/f9d611e3d0a5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
You need to log in before you can comment on or make changes to this bug.