Closed Bug 695458 Opened 8 years ago Closed 8 years ago

Android Prefs

Categories

(Firefox for Android :: General, defect, P1)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: elan, Assigned: bnicholson)

References

Details

(Keywords: feature, Whiteboard: [birch] [ux needed] [Product Approved)

Attachments

(2 files, 1 obsolete file)

Text Size

    Default zoom (on page load)

    Open Pages in overview

    Text encoding 

    Block popups

    landscape-only 

    home page

    privacy settings

    enable geolocation

    remember passwords
Assignee: nobody → alexp
Whiteboard: [birch]
Summary: Preferences- UI Needed → Android Prefs
Whiteboard: [birch] → [birch] [ux needed]
Assignee: alexp → bnicholson
Depends on: 694688
Status: NEW → ASSIGNED
Attached patch adds most prefs from XUL fennec (obsolete) — Splinter Review
patch requires patch from bug 694688
Attachment #569222 - Flags: review?(mark.finkle)
Although the homepage can be set in the prefs UI, the browser doesn't actually honor the browser.startup.homepage preference. See bug 696950.
Comment on attachment 569222 [details] [diff] [review]
adds most prefs from XUL fennec

>diff --git a/mobile/chrome/content/browser.js b/mobile/chrome/content/browser.js

>   getPreferences: function getPreferences(aPrefNames) {

>+        switch (prefName) {
>+          case "network.cookie.cookieBehavior":

Add a comment above the switch so we know you are doing specific tweaks to specific preferences. I wonder if there is a better way to handle these. Maybe there isn't. In a XUL app, some of this tweaking would be in the XUL UI code.

>   setPreferences: function setPreferences(aPref) {

>+    switch (json.name) {
>+      case "network.cookie.cookieBehavior":

Same kind of comment here
Attachment #569222 - Flags: review?(mark.finkle) → review+
r+ with nits fixed
Attachment #569222 - Attachment is obsolete: true
https://hg.mozilla.org/projects/birch/rev/2f77b085a9d0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attachment #569517 - Flags: review?(mark.finkle)
Attachment #569517 - Flags: review?(mark.finkle) → review+
Nice!

Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111026 Firefox/10.0a1 Fennec/10.0a1
Status: RESOLVED → VERIFIED
Whiteboard: [birch] [ux needed] → [birch] [ux needed] [Product Approved
tracking-fennec: --- → 11+
Keywords: feature
You need to log in before you can comment on or make changes to this bug.