695458 - Android Prefs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Erin Lancaster [:elan]]

Text Size

    Default zoom (on page load)

    Open Pages in overview

    Text encoding 

    Block popups

    landscape-only 

    home page

    privacy settings

    enable geolocation

    remember passwords

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: adds most prefs from XUL fennec

patch requires patch from bug 694688

Comment 2

[Brian Nicholson (:bnicholson)]

Although the homepage can be set in the prefs UI, the browser doesn't actually honor the browser.startup.homepage preference. See bug 696950.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 569222 [details] [diff] [review]
adds most prefs from XUL fennec

>diff --git a/mobile/chrome/content/browser.js b/mobile/chrome/content/browser.js

>   getPreferences: function getPreferences(aPrefNames) {

>+        switch (prefName) {
>+          case "network.cookie.cookieBehavior":

Add a comment above the switch so we know you are doing specific tweaks to specific preferences. I wonder if there is a better way to handle these. Maybe there isn't. In a XUL app, some of this tweaking would be in the XUL UI code.

>   setPreferences: function setPreferences(aPref) {

>+    switch (json.name) {
>+      case "network.cookie.cookieBehavior":

Same kind of comment here

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

r+ with nits fixed

Comment 5

[Brian Nicholson (:bnicholson)]

Attachment: rebased and added mfinkle's fixes

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/2f77b085a9d0

Comment 7

[Brian Nicholson (:bnicholson)]

Attachment: fixes crash from last patch

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/1f61c869b696

pushed followup

Comment 9

[Aaron Train [:aaronmt]]

Nice!

Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111026 Firefox/10.0a1 Fennec/10.0a1