696950 - Homepage preference not used at start

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Brian Nicholson (:bnicholson)]

about:home is always loaded.  We should use the browser.startup.homepage preference.

Comment 1

[Doug Turner (:dougt)]

other regions (mozilla china, etc) will want to change this value.

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: patch

browser now uses homepage preference

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: patch v2

disables lasturi loading in GeckoApp which prevented home page from loading

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 569881 [details] [diff] [review]
patch v2

This breaks the whole "show the last screenshot that was saved".  I think it would be better if we timed out using the last screenshot.  when enough time passes, we do what you are doing.  otherwise, we do what we were doing.

Comment 5

[Brian Nicholson (:bnicholson)]

This shouldn't break the screenshot, just the loading of the last URI (which we want to do if we are loading the homepage instead).

Comment 7

[Doug Turner (:dougt)]

Comment on attachment 569881 [details] [diff] [review]
patch v2

as discussed.

Comment 8

[Brian Nicholson (:bnicholson)]

Attachment: patch v3

This patch only activates the homepage if there's no saved state (i.e., this is a fresh start).  This follows the same behavior of the stock browser.

Comment 9

[Doug Turner (:dougt)]

Comment on attachment 573015 [details] [diff] [review]
patch v3

Review of attachment 573015 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/chrome/content/browser.js
@@ +404,5 @@
> +            // if homepage preference doesn't exist, give the default
> +            if (prefName == "browser.startup.homepage")
> +              pref.value = "about:home";
> +            else
> +              continue;

you should put this in mobile.js.

::: mobile/components/BrowserCLH.js
@@ +35,5 @@
> +    }
> +    try {
> +      let cmdUrl = aCmdLine.handleFlagWithParam("remote", false);
> +      if (cmdUrl)
> +        urlParam = cmdUrl;

Do we need to fix up this url, or just use it as-is?

Comment 10

[Brian Nicholson (:bnicholson)]

Attachment: patch v4

patch with prefs changes

Comment 11

[Brian Nicholson (:bnicholson)]

Attachment: patch v4

moves pref to mobile.js

Comment 12

[Doug Turner (:dougt)]

[Thu Nov 10 21:28:56 dougt@dougt:~/builds/birch ] $ hg qpush
applying attachment.cgi?id=573742
patching file embedding/android/GeckoApp.java
Hunk #1 FAILED at 94
Hunk #2 FAILED at 359
Hunk #3 FAILED at 535
Hunk #5 FAILED at 1023
4 out of 5 hunks FAILED -- saving rejects to file embedding/android/GeckoApp.java.rej
patching file mobile/components/BrowserCLH.js
Hunk #1 FAILED at 21
1 out of 1 hunks FAILED -- saving rejects to file mobile/components/BrowserCLH.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh attachment.cgi?id=573742

Comment 13

[Brian Nicholson (:bnicholson)]

Attachment: patch v5

rebased

Comment 14

[Brian Nicholson (:bnicholson)]

Attachment: patch v6

rebased

Comment 15

[Steffen Wilberg]

Patch v6 has been bitrotted again by the directory moves...

Comment 17

[Verdi [:verdi] Best to slack me]

Using today's nightly, I can't get the homepage setting to work at all. No matter what I set it to it reverts to "Firefox Start" after restarting. Also it doesn't display the Firefox Start page it displays some random page I looked a few days ago.

Comment 18

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Verdi from comment #17)
> Using today's nightly, I can't get the homepage setting to work at all. No
> matter what I set it to it reverts to "Firefox Start" after restarting. Also
> it doesn't display the Firefox Start page it displays some random page I
> looked a few days ago.

We are killing the preference.

Comment 21

[Markus Popp]

(In reply to Mark Finkle (:mfinkle) from comment #18)
> We are killing the preference.

Does that mean there will no longer be a way to set a home page other than about:home, or will there be another way to do that?