695699 - update.locale support

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Erin Lancaster [:elan]]

* nightly builds are already being generated; need to generate snippets?
* only needed for nightly/aurora
* not required, but useful for testing/dogfooding
* Need to turn on check for updates

Comment 1

[Doug Turner (:dougt)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=694077#c20 for what has to be done on the client side.

Comment 2

[Doug Turner (:dougt)]

Attachment: short term work around

Comment 3

[Doug Turner (:dougt)]

Attachment: patch v. 1

This works for android, but not sure about other platforms.  needs to go to try.  Ted, does this look about right?

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 568845 [details] [diff] [review]
short term work around

Review of attachment 568845 [details] [diff] [review]:
-----------------------------------------------------------------

r+ since the real fix is in the second patch.

Comment 5

[Doug Turner (:dougt)]

work around on birch:  http://hg.mozilla.org/projects/birch/rev/f84cfff96eae

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 568846 [details] [diff] [review]
patch v. 1

Doug, I'm slammed for at least this week so if you could get khuey or Ted to take a look at this it will likely happen faster.

Couple of quick comments.
I think it would be a good thing to be available even with builds that don't include the updater.
I think it would be best to name it platformLocale or something similar instead of locale to avoid ambiguity with the locale currently in use.

Comment 7

[Mike Hommey [:glandium]]

FTR, the attached patch applies on birch, not on m-c. It is on top of the hack that landed on birch for bug 686466.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Embed locale information in nsXREAppData instead of shipping an update.locale file. Original patch by dougt

Pushed to try:
https://tbpl.mozilla.org/?noignore=1&tree=Try&rev=1a3aff53cc8c

I didn't include the part adding locale information from platform.ini because the updater actually doesn't look there. The updater doesn't seem to be able to care about application and XRE separately anyways. So only one information is required, and that is that of the locale bundled in the application. Thus the name of the variable.

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 569996 [details] [diff] [review]
Embed locale information in nsXREAppData instead of shipping an update.locale file. Original patch by dougt

It breaks all tests on windows and xpcshell on all platforms

Comment 10

[Mike Hommey [:glandium]]

Attachment: Embed locale information in nsXREAppData instead of shipping an update.locale file. Original patch by dougt

Was missing an update to the script generating application.ini.h

https://tbpl.mozilla.org/?noignore=1&tree=Try&rev=0a8e1e439f59

Comment 11

[Mike Hommey [:glandium]]

Still breaks windows :(

Comment 12

[Mike Hommey [:glandium]]

Now that I think of it, hardcoding the locale in the binary is not going to work with l10n repacking :-/

So in the end, bug 696555 is probably the way to go.

Comment 13

[Mike Hommey [:glandium]]

<rs> glandium: then moving the file into omni.jar or a similar method sounds like the only course available

We'll thus go the bug 696555 way.