696555 - Move update.locale into omni.jar

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Mike Hommey [:glandium]]

If I'm not mistaken, the update.locale file is only read from the nsUpdateService.js, and is gotten from FileUtils.getFile(KEY_APPDIR, [FILE_UPDATE_LOCALE]) and FileUtils.getFile(KEY_GRED, [FILE_UPDATE_LOCALE]) if the former doesn't exist.
On Fennec, this means we need to extract the file so that it lives in the application directory. We could move it into the omni.jar, with the result that Fennec doesn't need to extract it. We should then be able to use resource://app/update.locale and resource://gre/update.locale to get the file instead of the FileUtils.getFile calls above.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Move update.locale into omni.jar

This is untested, but should work.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Move update.locale into omni.jar

Should be better like this

Comment 3

[Doug Turner (:dougt)]

I think we want to remove update.locale all together.  See bug 695699.

Comment 4

[Mike Hommey [:glandium]]

Let's go for bug 695699

Comment 5

[Mike Hommey [:glandium]]

In the end, we're going to do it this way.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Move update.locale into omni.jar

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 570753 [details] [diff] [review]
Move update.locale into omni.jar

<rs> glandium: if tests pass r=me
(...)
<rs> glandium: I took a quick look and I'm fine with you taking my word from irc

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/385846d8b780

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/385846d8b780