695743 - Save as PDF

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Add a "Save as PDF" menu item

Patch to add PDF printing support. It silently saves a PDF into the Download folder on the sdcard, assuming the patch in the dependent bug is applied.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 569184 [details] [diff] [review]
Add a "Save as PDF" menu item


>diff --git a/embedding/android/GeckoApp.java b/embedding/android/GeckoApp.java

>+           case R.id.saveaspdf:
>+               GeckoAppShell.sendEventToGecko(new GeckoEvent("save-as-pdf", null));

I'm on a mission to use consistent event/message names. Can we use "SaveAs:PDF"

>diff --git a/embedding/android/locales/en-US/android_strings.dtd b/embedding/android/locales/en-US/android_strings.dtd
>diff --git a/mobile/chrome/content/browser.js b/mobile/chrome/content/browser.js

>+    Services.obs.addObserver(this, "save-as-pdf", false);

Same

>+  saveAsPDF: function saveAsPDF(browser) {

nit: aBrowser

r+

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Madhava might want a string change, but "Save as PDF" is good for now

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Add a "Save as PDF" menu item (v2)

Updated as requested, rebased to latest birch code.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/18c90fce8d82

Comment 6

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111026 Firefox/10.0a1 Fennec/10.0a1