Status

()

defect
P3
normal
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

(Whiteboard: [QA+])

Attachments

(1 attachment, 1 obsolete attachment)

No description provided.
Depends on: 696875
Posted patch Add a "Save as PDF" menu item (obsolete) — Splinter Review
Patch to add PDF printing support. It silently saves a PDF into the Download folder on the sdcard, assuming the patch in the dependent bug is applied.
Attachment #569184 - Flags: review?(mark.finkle)
Comment on attachment 569184 [details] [diff] [review]
Add a "Save as PDF" menu item


>diff --git a/embedding/android/GeckoApp.java b/embedding/android/GeckoApp.java

>+           case R.id.saveaspdf:
>+               GeckoAppShell.sendEventToGecko(new GeckoEvent("save-as-pdf", null));

I'm on a mission to use consistent event/message names. Can we use "SaveAs:PDF"

>diff --git a/embedding/android/locales/en-US/android_strings.dtd b/embedding/android/locales/en-US/android_strings.dtd
>diff --git a/mobile/chrome/content/browser.js b/mobile/chrome/content/browser.js

>+    Services.obs.addObserver(this, "save-as-pdf", false);

Same

>+  saveAsPDF: function saveAsPDF(browser) {

nit: aBrowser

r+
Attachment #569184 - Flags: review?(mark.finkle) → review+
Madhava might want a string change, but "Save as PDF" is good for now
Whiteboard: [QA+]
Updated as requested, rebased to latest birch code.
Attachment #569184 - Attachment is obsolete: true
Attachment #569396 - Flags: review+
https://hg.mozilla.org/projects/birch/rev/18c90fce8d82
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 697417
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111026 Firefox/10.0a1 Fennec/10.0a1
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
You need to log in before you can comment on or make changes to this bug.