Closed Bug 696875 Opened 14 years ago Closed 14 years ago

Widget component interfaces not getting registered

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file, 1 obsolete file)

Trying to access widget component interfaces in javascript (e.g. doing Components.interfaces.nsIPrintSettingsService) doesn't work as expected. The reason for this appears to be that the widget/public/Makefile.in defines XPIDL_MODULE to be "widget", as does the widget/src/android/Makefile.in. This causes the android XPT file to clobber the widget XPT file, and so the only interface getting picked up is nsIAndroidBridge.
Attached patch Rename XPIDL_MODULE (obsolete) — Splinter Review
Attachment #569177 - Flags: review?(doug.turner)
why widget_fennec and not widget_android?
Oh, whoops. I wasn't sure if widget_android would conflict with LIBRARY_NAME in some way (I looked at the widget/src/cocoa/ folder for inspiration and it had different names for LIBRARY_NAME and XPIDL_MODULE) so I used _fennec and forgot to test _android too. I can try _android as well to see if that works.
Comment on attachment 569177 [details] [diff] [review] Rename XPIDL_MODULE can't use the product name here. can we use widget_android?
Attachment #569177 - Flags: review?(doug.turner) → review-
Updated to widget_android
Attachment #569177 - Attachment is obsolete: true
Attachment #569395 - Flags: review?(doug.turner)
Attachment #569395 - Flags: review?(doug.turner) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: