Last Comment Bug 695756 - Implement js::BooleanObject
: Implement js::BooleanObject
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: mozilla10
Assigned To: Terrence Cole [:terrence]
:
:
Mentors:
Depends on: 727987
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-19 11:01 PDT by Terrence Cole [:terrence]
Modified: 2012-03-17 08:50 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1: implements BooleanObject (11.28 KB, patch)
2011-10-19 11:01 PDT, Terrence Cole [:terrence]
n.nethercote: review+
Details | Diff | Splinter Review

Description Terrence Cole [:terrence] 2011-10-19 11:01:53 PDT
Created attachment 568113 [details] [diff] [review]
v1: implements BooleanObject

BooleanObject is the last primitive value type not to have an object wrapper in vm.  Sadly, this patch is mostly for the sake of rounding things out, rather than for code simplification, although there is a bit of that.
Comment 1 Nicholas Nethercote [:njn] 2011-10-20 17:42:05 PDT
Comment on attachment 568113 [details] [diff] [review]
v1: implements BooleanObject

Review of attachment 568113 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Comment 2 Nicholas Nethercote [:njn] 2011-10-20 22:51:09 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/986f31890872
Comment 3 Nicholas Nethercote [:njn] 2011-10-20 23:15:33 PDT
Bustage fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d031d09fe889
Comment 5 :Ms2ger (⌚ UTC+1/+2) 2011-10-21 08:44:06 PDT
Comment on attachment 568113 [details] [diff] [review]
v1: implements BooleanObject

>--- a/js/src/jsbool.cpp
>+++ b/js/src/jsbool.cpp
>@@ -49,16 +49,17 @@
> #include "jscntxt.h"
> #include "jsinfer.h"
> #include "jsversion.h"
> #include "jslock.h"
> #include "jsnum.h"
> #include "jsobj.h"
> #include "jsstr.h"
> 
>+#include "vm/BooleanObject-inl.h"
> #include "vm/GlobalObject.h"
> 
> #include "jsinferinlines.h"
> #include "jsobjinlines.h"
> #include "jsstrinlines.h"

The order is js*.h; */*.h; js*inlines.h; */*-inl.h.
Comment 6 Terrence Cole [:terrence] 2011-10-21 09:04:13 PDT
(In reply to Ms2ger from comment #5)
> The order is js*.h; */*.h; js*inlines.h; */*-inl.h.

That's by far the clearest explanation of our header ordering that I've yet seen.  Could you update the wiki at https://wiki.mozilla.org/JavaScript:SpiderMonkey:C%2B%2B_Coding_Style with that?  The existing example, while correct, did not do a great job of making clear what exactly our policy is.
Comment 7 Terrence Cole [:terrence] 2011-10-25 09:00:32 PDT
Resetting fields.  Note to self: Always refresh with Ctrl+F5.

Note You need to log in before you can comment on or make changes to this bug.