695756 - Implement js::BooleanObject

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Terrence Cole [:terrence]]

Attachment: v1: implements BooleanObject

BooleanObject is the last primitive value type not to have an object wrapper in vm.  Sadly, this patch is mostly for the sake of rounding things out, rather than for code simplification, although there is a bit of that.

Comment 1

[Nicholas Nethercote [inactive]]

Comment on attachment 568113 [details] [diff] [review]
v1: implements BooleanObject

Review of attachment 568113 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 2

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/986f31890872

Comment 3

[Nicholas Nethercote [inactive]]

Bustage fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d031d09fe889

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/986f31890872
https://hg.mozilla.org/mozilla-central/rev/d031d09fe889

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 568113 [details] [diff] [review]
v1: implements BooleanObject

>--- a/js/src/jsbool.cpp
>+++ b/js/src/jsbool.cpp
>@@ -49,16 +49,17 @@
> #include "jscntxt.h"
> #include "jsinfer.h"
> #include "jsversion.h"
> #include "jslock.h"
> #include "jsnum.h"
> #include "jsobj.h"
> #include "jsstr.h"
> 
>+#include "vm/BooleanObject-inl.h"
> #include "vm/GlobalObject.h"
> 
> #include "jsinferinlines.h"
> #include "jsobjinlines.h"
> #include "jsstrinlines.h"

The order is js*.h; */*.h; js*inlines.h; */*-inl.h.

Comment 6

[Terrence Cole [:terrence]]

(In reply to Ms2ger from comment #5)
> The order is js*.h; */*.h; js*inlines.h; */*-inl.h.

That's by far the clearest explanation of our header ordering that I've yet seen.  Could you update the wiki at https://wiki.mozilla.org/JavaScript:SpiderMonkey:C%2B%2B_Coding_Style with that?  The existing example, while correct, did not do a great job of making clear what exactly our policy is.

Comment 7

[Terrence Cole [:terrence]]

Resetting fields.  Note to self: Always refresh with Ctrl+F5.