The default bug view has changed. See this FAQ.

Implement js::BooleanObject

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
--
enhancement
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 568113 [details] [diff] [review]
v1: implements BooleanObject

BooleanObject is the last primitive value type not to have an object wrapper in vm.  Sadly, this patch is mostly for the sake of rounding things out, rather than for code simplification, although there is a bit of that.
(Assignee)

Updated

6 years ago
Attachment #568113 - Flags: review?(nnethercote)
Comment on attachment 568113 [details] [diff] [review]
v1: implements BooleanObject

Review of attachment 568113 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #568113 - Flags: review?(nnethercote) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/986f31890872
Bustage fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d031d09fe889
https://hg.mozilla.org/mozilla-central/rev/986f31890872
https://hg.mozilla.org/mozilla-central/rev/d031d09fe889
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Comment on attachment 568113 [details] [diff] [review]
v1: implements BooleanObject

>--- a/js/src/jsbool.cpp
>+++ b/js/src/jsbool.cpp
>@@ -49,16 +49,17 @@
> #include "jscntxt.h"
> #include "jsinfer.h"
> #include "jsversion.h"
> #include "jslock.h"
> #include "jsnum.h"
> #include "jsobj.h"
> #include "jsstr.h"
> 
>+#include "vm/BooleanObject-inl.h"
> #include "vm/GlobalObject.h"
> 
> #include "jsinferinlines.h"
> #include "jsobjinlines.h"
> #include "jsstrinlines.h"

The order is js*.h; */*.h; js*inlines.h; */*-inl.h.
(Assignee)

Comment 6

6 years ago
(In reply to Ms2ger from comment #5)
> The order is js*.h; */*.h; js*inlines.h; */*-inl.h.

That's by far the clearest explanation of our header ordering that I've yet seen.  Could you update the wiki at https://wiki.mozilla.org/JavaScript:SpiderMonkey:C%2B%2B_Coding_Style with that?  The existing example, while correct, did not do a great job of making clear what exactly our policy is.
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
Target Milestone: mozilla10 → ---
(Assignee)

Comment 7

6 years ago
Resetting fields.  Note to self: Always refresh with Ctrl+F5.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Depends on: 727987
You need to log in before you can comment on or make changes to this bug.