Closed Bug 695756 Opened 8 years ago Closed 8 years ago

Implement js::BooleanObject

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

BooleanObject is the last primitive value type not to have an object wrapper in vm.  Sadly, this patch is mostly for the sake of rounding things out, rather than for code simplification, although there is a bit of that.
Attachment #568113 - Flags: review?(nnethercote)
Comment on attachment 568113 [details] [diff] [review]
v1: implements BooleanObject

Review of attachment 568113 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #568113 - Flags: review?(nnethercote) → review+
https://hg.mozilla.org/mozilla-central/rev/986f31890872
https://hg.mozilla.org/mozilla-central/rev/d031d09fe889
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Comment on attachment 568113 [details] [diff] [review]
v1: implements BooleanObject

>--- a/js/src/jsbool.cpp
>+++ b/js/src/jsbool.cpp
>@@ -49,16 +49,17 @@
> #include "jscntxt.h"
> #include "jsinfer.h"
> #include "jsversion.h"
> #include "jslock.h"
> #include "jsnum.h"
> #include "jsobj.h"
> #include "jsstr.h"
> 
>+#include "vm/BooleanObject-inl.h"
> #include "vm/GlobalObject.h"
> 
> #include "jsinferinlines.h"
> #include "jsobjinlines.h"
> #include "jsstrinlines.h"

The order is js*.h; */*.h; js*inlines.h; */*-inl.h.
(In reply to Ms2ger from comment #5)
> The order is js*.h; */*.h; js*inlines.h; */*-inl.h.

That's by far the clearest explanation of our header ordering that I've yet seen.  Could you update the wiki at https://wiki.mozilla.org/JavaScript:SpiderMonkey:C%2B%2B_Coding_Style with that?  The existing example, while correct, did not do a great job of making clear what exactly our policy is.
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
Target Milestone: mozilla10 → ---
Resetting fields.  Note to self: Always refresh with Ctrl+F5.
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.