Add antialiasing to the downloadable blocklist

RESOLVED FIXED in mozilla10

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: drs, Assigned: drs)

Tracking

Trunk
mozilla10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

6 years ago
Support for blocking antialiasing if vendor/device/OS match a pre-determined bad setup must be added to the downloadable blocklist.
(Assignee)

Updated

6 years ago
Assignee: nobody → dsherk
Depends on: 615976
(Assignee)

Comment 1

6 years ago
Created attachment 568268 [details] [diff] [review]
Patch v1.0, blocklisting for MSAA.

Allows blocklisting of MSAA through downloaded blocklist or static code.
Attachment #568268 - Flags: review?(jgilbert)
(Assignee)

Comment 2

6 years ago
Created attachment 568269 [details] [diff] [review]
Patch v1.0, force MSAA.

Allows users to force MSAA on by setting the webgl.msaa-force pref to true.
Attachment #568269 - Flags: review?(jgilbert)
Comment on attachment 568269 [details] [diff] [review]
Patch v1.0, force MSAA.

># HG changeset patch
># Parent 54159f8b6372997bc05b2bfae2de89fb02c6e1d9
># User Doug Sherk <dsherk@mozilla.com>
>Bug 695912: allow forcing MSAA on r=jgilbert
[...]
>+    bool forceMSAA =
>+        Preferences::GetBool("webgl.msaa-force", false);

Since this should never change, I'd rather we use 'const bool' here. R+ though.
Attachment #568269 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 568548 [details] [diff] [review]
Patch v1.1, blocklisting for MSAA.

Updated to include ATI blocks.
Attachment #568268 - Attachment is obsolete: true
Attachment #568268 - Flags: review?(jgilbert)
Attachment #568548 - Flags: review?(jgilbert)
(Assignee)

Comment 5

6 years ago
Created attachment 568552 [details] [diff] [review]
Patch v1.1, blocklisting for MSAA.

Removed accidentally added character in a comment.
Attachment #568548 - Attachment is obsolete: true
Attachment #568548 - Flags: review?(jgilbert)
Attachment #568552 - Flags: review?(jgilbert)
Comment on attachment 568552 [details] [diff] [review]
Patch v1.1, blocklisting for MSAA.

Good, R+ but:
>diff --git a/widget/src/xpwidgets/GfxInfoBase.cpp b/widget/src/xpwidgets/GfxInfoBase.cpp
>--- a/widget/src/xpwidgets/GfxInfoBase.cpp
>+++ b/widget/src/xpwidgets/GfxInfoBase.cpp
>@@ -152,16 +152,18 @@ GetPrefNameForFeature(PRInt32 aFeature)
>       name = BLACKLIST_PREF_BRANCH "layers.opengl";
>       break;
>     case nsIGfxInfo::FEATURE_WEBGL_OPENGL:
>       name = BLACKLIST_PREF_BRANCH "webgl.opengl";
>       break;
>     case nsIGfxInfo::FEATURE_WEBGL_ANGLE:
>       name = BLACKLIST_PREF_BRANCH "webgl.angle";
>       break;
>+    case nsIGfxInfo::FEATURE_WEBGL_MSAA:
>+      name = BLACKLIST_PREF_BRANCH "webgl.msaa";
>     default:
>       break;
>   };
> 
>   return name;
> }

Even though it falls through to 'default: break;', it should have its own 'break', for future-proofing.
Attachment #568552 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 7

6 years ago
Created attachment 568562 [details] [diff] [review]
Patch v1.1, blocklisting for MSAA.

Previous comment fixed, +r carried.
Attachment #568552 - Attachment is obsolete: true
Attachment #568562 - Flags: review+
(Assignee)

Updated

6 years ago
Depends on: 668004
(Assignee)

Comment 8

6 years ago
Running on Try: https://tbpl.mozilla.org/?tree=Try&rev=20a50709f71c
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7a96e8bec7e
and 2nd patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/5119eb1f191b
https://hg.mozilla.org/mozilla-central/rev/b7a96e8bec7e
https://hg.mozilla.org/mozilla-central/rev/5119eb1f191b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Depends on: 718039
You need to log in before you can comment on or make changes to this bug.