695912 - Add antialiasing to the downloadable blocklist

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Doug Sherk (:drs) (inactive)]

Support for blocking antialiasing if vendor/device/OS match a pre-determined bad setup must be added to the downloadable blocklist.

Comment 1

[Doug Sherk (:drs) (inactive)]

Attachment: Patch v1.0, blocklisting for MSAA.

Allows blocklisting of MSAA through downloaded blocklist or static code.

Comment 2

[Doug Sherk (:drs) (inactive)]

Attachment: Patch v1.0, force MSAA.

Allows users to force MSAA on by setting the webgl.msaa-force pref to true.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 568269 [details] [diff] [review]
Patch v1.0, force MSAA.

># HG changeset patch
># Parent 54159f8b6372997bc05b2bfae2de89fb02c6e1d9
># User Doug Sherk <[e-mail]>
>Bug 695912: allow forcing MSAA on r=jgilbert
[...]
>+    bool forceMSAA =
>+        Preferences::GetBool("webgl.msaa-force", false);

Since this should never change, I'd rather we use 'const bool' here. R+ though.

Comment 4

[Doug Sherk (:drs) (inactive)]

Attachment: Patch v1.1, blocklisting for MSAA.

Updated to include ATI blocks.

Comment 5

[Doug Sherk (:drs) (inactive)]

Attachment: Patch v1.1, blocklisting for MSAA.

Removed accidentally added character in a comment.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 568552 [details] [diff] [review]
Patch v1.1, blocklisting for MSAA.

Good, R+ but:
>diff --git a/widget/src/xpwidgets/GfxInfoBase.cpp b/widget/src/xpwidgets/GfxInfoBase.cpp
>--- a/widget/src/xpwidgets/GfxInfoBase.cpp
>+++ b/widget/src/xpwidgets/GfxInfoBase.cpp
>@@ -152,16 +152,18 @@ GetPrefNameForFeature(PRInt32 aFeature)
>       name = BLACKLIST_PREF_BRANCH "layers.opengl";
>       break;
>     case nsIGfxInfo::FEATURE_WEBGL_OPENGL:
>       name = BLACKLIST_PREF_BRANCH "webgl.opengl";
>       break;
>     case nsIGfxInfo::FEATURE_WEBGL_ANGLE:
>       name = BLACKLIST_PREF_BRANCH "webgl.angle";
>       break;
>+    case nsIGfxInfo::FEATURE_WEBGL_MSAA:
>+      name = BLACKLIST_PREF_BRANCH "webgl.msaa";
>     default:
>       break;
>   };
> 
>   return name;
> }

Even though it falls through to 'default: break;', it should have its own 'break', for future-proofing.

Comment 7

[Doug Sherk (:drs) (inactive)]

Attachment: Patch v1.1, blocklisting for MSAA.

Previous comment fixed, +r carried.

Comment 8

[Doug Sherk (:drs) (inactive)]

Running on Try: https://tbpl.mozilla.org/?tree=Try&rev=20a50709f71c

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7a96e8bec7e

Comment 10

[Benoit Jacob [:bjacob] (mostly away)]

and 2nd patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/5119eb1f191b

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b7a96e8bec7e
https://hg.mozilla.org/mozilla-central/rev/5119eb1f191b