696027 - Extensions installed into the profile will be disabled once bug 693743 has been landed

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With the landing of the patch on bug 693743, Mozmill is still able to install extensions into the profile folder but all of those will be disabled. We have to exclude the profile folder from auto-disabling extension installation.

For more information see the Add-ons SDK bug 695436 comment 0.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This has to be fixed across all branches ASAP. We also have to release new versions of Mozmill once the patches have been landed.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1 [checked-in]

With this patch we ensure that extensions dropped into the profile folder, including mozmill and jsbridge, are not getting disabled on startup due to the 3rd party add-on check.

Keep in mind that the documentation on MDN is currently not correct and mentions old values for those scopes. I have already requested an update. The current values can be found here:

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/AddonManager.jsm#1258

Comment 3

[Jeff Hammel]

Comment on attachment 568353 [details] [diff] [review]
Patch v1 [checked-in]

works for me

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 568353 [details] [diff] [review]
Patch v1 [checked-in]

Landed as:
https://github.com/mozautomation/mozmill/commit/d14743a10d153386bae7639de03e1d686f85c380

I will follow-up with a patch for Mozmill 2 and 2.1

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch (master) [checked-in]

Not sure about the current branch state of master and mozmill 2. So this is only a diff against the new mozbase repo.

Comment 6

[Jeff Hammel]

Comment on attachment 568626 [details] [diff] [review]
Patch (master) [checked-in]

wfm

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 568626 [details] [diff] [review]
Patch (master) [checked-in]

https://github.com/mozilla/mozbase/commit/dfeb07adfd0883b0a14c3c9497011a06b2009e14

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Also landed on hotfix-2.0:
https://github.com/mozautomation/mozmill/commit/d177d6305405db09a8d877d61738957a9bdc697c

We are done now. Thanks for the quick turnaround.