696205 - Consider adding an optimization for id selectors to querySelectorAll

Status: RESOLVED FIXED

Description

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

It's easy to do, so might as well.  I do think the extra complexity is probably worth it....

Comment 1

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Created attachment 568506 [details] [diff] [review]
part 1.  Refactor querySelector and querySelectorAll so that there is only one codepath to modify.

Comment 2

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Created attachment 568512 [details] [diff] [review]
part 2.  Add a querySelector fast-path for selectors whose rightmost sequence of simple selectors contains an id.

Comment 3

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Created attachment 568703 [details] [diff] [review]
part 1.  Refactor querySelector and querySelectorAll so that there is only one codepath to modify.

Comment 4

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

  http://hg.mozilla.org/integration/mozilla-inbound/rev/829a99f28b5c
  http://hg.mozilla.org/integration/mozilla-inbound/rev/b068485e4cc2

Comment 5

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

https://hg.mozilla.org/mozilla-central/rev/829a99f28b5c
https://hg.mozilla.org/mozilla-central/rev/b068485e4cc2