Consider adding an optimization for id selectors to querySelectorAll

RESOLVED FIXED in mozilla10

Status

()

Core
DOM
P2
normal
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla10
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

It's easy to do, so might as well.  I do think the extra complexity is probably worth it....
Created attachment 568506 [details] [diff] [review]
part 1.  Refactor querySelector and querySelectorAll so that there is only one codepath to modify.
Attachment #568506 - Flags: review?(jonas)
Created attachment 568512 [details] [diff] [review]
part 2.  Add a querySelector fast-path for selectors whose rightmost sequence of simple selectors contains an id.
Attachment #568512 - Flags: review?(jonas)
Whiteboard: [need review]
Version: unspecified → Trunk
Created attachment 568703 [details] [diff] [review]
part 1.  Refactor querySelector and querySelectorAll so that there is only one codepath to modify.
Attachment #568703 - Flags: review?(jonas)
Attachment #568506 - Attachment is obsolete: true
Attachment #568506 - Flags: review?(jonas)
Attachment #568703 - Flags: review?(jonas) → review+
Attachment #568512 - Flags: review?(jonas) → review+
  http://hg.mozilla.org/integration/mozilla-inbound/rev/829a99f28b5c
  http://hg.mozilla.org/integration/mozilla-inbound/rev/b068485e4cc2
Assignee: nobody → bzbarsky
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/829a99f28b5c
https://hg.mozilla.org/mozilla-central/rev/b068485e4cc2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Depends on: 698974

Updated

6 years ago
Depends on: 738108
Depends on: 1282787
You need to log in before you can comment on or make changes to this bug.