Last Comment Bug 696205 - Consider adding an optimization for id selectors to querySelectorAll
: Consider adding an optimization for id selectors to querySelectorAll
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: P2 normal (vote)
: mozilla10
Assigned To: Boris Zbarsky [:bz]
:
Mentors:
Depends on: 698974 738108 1282787
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-20 13:51 PDT by Boris Zbarsky [:bz]
Modified: 2016-06-28 16:01 PDT (History)
6 users (show)
bzbarsky: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
part 1. Refactor querySelector and querySelectorAll so that there is only one codepath to modify. (4.06 KB, patch)
2011-10-20 13:58 PDT, Boris Zbarsky [:bz]
no flags Details | Diff | Splinter Review
part 2. Add a querySelector fast-path for selectors whose rightmost sequence of simple selectors contains an id. (8.73 KB, patch)
2011-10-20 14:11 PDT, Boris Zbarsky [:bz]
jonas: review+
Details | Diff | Splinter Review
part 1. Refactor querySelector and querySelectorAll so that there is only one codepath to modify. (4.06 KB, patch)
2011-10-21 10:37 PDT, Boris Zbarsky [:bz]
jonas: review+
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] 2011-10-20 13:51:33 PDT
It's easy to do, so might as well.  I do think the extra complexity is probably worth it....
Comment 1 Boris Zbarsky [:bz] 2011-10-20 13:58:00 PDT
Created attachment 568506 [details] [diff] [review]
part 1.  Refactor querySelector and querySelectorAll so that there is only one codepath to modify.
Comment 2 Boris Zbarsky [:bz] 2011-10-20 14:11:48 PDT
Created attachment 568512 [details] [diff] [review]
part 2.  Add a querySelector fast-path for selectors whose rightmost sequence of simple selectors contains an id.
Comment 3 Boris Zbarsky [:bz] 2011-10-21 10:37:28 PDT
Created attachment 568703 [details] [diff] [review]
part 1.  Refactor querySelector and querySelectorAll so that there is only one codepath to modify.

Note You need to log in before you can comment on or make changes to this bug.