Closed Bug 696205 Opened 10 years ago Closed 10 years ago

Consider adding an optimization for id selectors to querySelectorAll

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla10

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(2 files, 1 obsolete file)

part 2. Add a querySelector fast-path for selectors whose rightmost sequence of simple selectors contains an id.
8.73 KB, patch
sicking
: review+
Details | Diff | Splinter Review
part 1. Refactor querySelector and querySelectorAll so that there is only one codepath to modify.
4.06 KB, patch
sicking
: review+
Details | Diff | Splinter Review 
It's easy to do, so might as well.  I do think the extra complexity is probably worth it....
Whiteboard: [need review]
Version: unspecified → Trunk
Attachment #568506 - Attachment is obsolete: true
Attachment #568506 - Flags: review?(jonas)
  http://hg.mozilla.org/integration/mozilla-inbound/rev/829a99f28b5c
  http://hg.mozilla.org/integration/mozilla-inbound/rev/b068485e4cc2
Assignee: nobody → bzbarsky
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla10
Depends on: 698974
Depends on: 738108
Depends on: 1282787
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.