Consider adding an optimization for id selectors to querySelectorAll
RESOLVED
FIXED
in mozilla10
Status
()
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(2 attachments, 1 obsolete attachment)
|
8.73 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
|
4.06 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
It's easy to do, so might as well. I do think the extra complexity is probably worth it....
|
(Assignee) | |
Comment 1•7 years ago
|
||
Created attachment 568506 [details] [diff] [review] part 1. Refactor querySelector and querySelectorAll so that there is only one codepath to modify.
Attachment #568506 -
Flags: review?(jonas)
|
|
(Assignee) | |
Comment 2•7 years ago
|
||
Created attachment 568512 [details] [diff] [review] part 2. Add a querySelector fast-path for selectors whose rightmost sequence of simple selectors contains an id.
Attachment #568512 -
Flags: review?(jonas)
|
|
(Assignee) | |
Updated•7 years ago
|
Whiteboard: [need review]
|
||
Updated•7 years ago
|
Version: unspecified → Trunk
|
|
(Assignee) | |
Comment 3•7 years ago
|
||
Created attachment 568703 [details] [diff] [review] part 1. Refactor querySelector and querySelectorAll so that there is only one codepath to modify.
Attachment #568703 -
Flags: review?(jonas)
|
|
(Assignee) | |
Updated•7 years ago
|
Attachment #568506 -
Attachment is obsolete: true
Attachment #568506 -
Flags: review?(jonas)
Attachment #568703 -
Flags: review?(jonas) → review+
Attachment #568512 -
Flags: review?(jonas) → review+
|
|
(Assignee) | |
Comment 4•7 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/829a99f28b5c http://hg.mozilla.org/integration/mozilla-inbound/rev/b068485e4cc2
Assignee: nobody → bzbarsky
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/829a99f28b5c https://hg.mozilla.org/mozilla-central/rev/b068485e4cc2
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•