698974 - querySelector on createDocumentFragment triggers "ASSERTION: Unexpected root node"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Jesse Ruderman]

Attachment: testcase

> ###!!! ASSERTION: Unexpected root node: 'aRoot->IsElement() || aRoot->IsNodeOfType(nsINode::eDOCUMENT)', file content/base/src/nsGenericElement.cpp, line 5395

> nsGenericElement::doQuerySelector [content/base/src/nsGenericElement.cpp:5463]
> nsIDOMNodeSelector_QuerySelector [dom_quickstubs.cpp:5689]

I'm guessing this is a regression from:

changeset:   b068485e4cc2
user:        Boris Zbarsky
date:        Mon Oct 31 22:50:50 2011 -0400
summary:     Bug 696205 part 2.  Add a querySelector fast-path for selectors whose rightmost sequence of simple selectors contains an id.  r=sicking

Comment 1

[Boris Zbarsky [:bzbarsky]]

Bah, indeed.  Fixing.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix assertion to not assert things that are just false.

Comment 3

[Jesse Ruderman]

What's the loop index change for?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixes a compiler warning...

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5883190e98aa

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5883190e98aa