Created attachment 571223 [details] testcase > ###!!! ASSERTION: Unexpected root node: 'aRoot->IsElement() || aRoot->IsNodeOfType(nsINode::eDOCUMENT)', file content/base/src/nsGenericElement.cpp, line 5395 > nsGenericElement::doQuerySelector [content/base/src/nsGenericElement.cpp:5463] > nsIDOMNodeSelector_QuerySelector [dom_quickstubs.cpp:5689] I'm guessing this is a regression from: changeset: b068485e4cc2 user: Boris Zbarsky date: Mon Oct 31 22:50:50 2011 -0400 summary: Bug 696205 part 2. Add a querySelector fast-path for selectors whose rightmost sequence of simple selectors contains an id. r=sicking
Bah, indeed. Fixing.
Assignee: nobody → bzbarsky
Priority: -- → P1
Created attachment 571236 [details] [diff] [review] Fix assertion to not assert things that are just false.
Attachment #571236 - Flags: review?(jonas)
What's the loop index change for?
Fixes a compiler warning...
Attachment #571236 - Flags: review?(jonas) → review+
Whiteboard: [need review]
Target Milestone: --- → mozilla10
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.