Closed Bug 698974 Opened 10 years ago Closed 10 years ago

querySelector on createDocumentFragment triggers "ASSERTION: Unexpected root node"

Categories

(Core :: DOM: Core & HTML, defect, P1)

x86_64
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(Keywords: assertion, regression, testcase)

Attachments

(2 files)

Attached file testcase
> ###!!! ASSERTION: Unexpected root node: 'aRoot->IsElement() || aRoot->IsNodeOfType(nsINode::eDOCUMENT)', file content/base/src/nsGenericElement.cpp, line 5395

> nsGenericElement::doQuerySelector [content/base/src/nsGenericElement.cpp:5463]
> nsIDOMNodeSelector_QuerySelector [dom_quickstubs.cpp:5689]

I'm guessing this is a regression from:

changeset:   b068485e4cc2
user:        Boris Zbarsky
date:        Mon Oct 31 22:50:50 2011 -0400
summary:     Bug 696205 part 2.  Add a querySelector fast-path for selectors whose rightmost sequence of simple selectors contains an id.  r=sicking
Bah, indeed.  Fixing.
Assignee: nobody → bzbarsky
Priority: -- → P1
Whiteboard: [need review]
What's the loop index change for?
Fixes a compiler warning...
https://hg.mozilla.org/integration/mozilla-inbound/rev/5883190e98aa
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/5883190e98aa
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.