Last Comment Bug 698974 - querySelector on createDocumentFragment triggers "ASSERTION: Unexpected root node"
: querySelector on createDocumentFragment triggers "ASSERTION: Unexpected root ...
Status: RESOLVED FIXED
: assertion, regression, testcase
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86_64 Mac OS X
: P1 normal (vote)
: mozilla10
Assigned To: Boris Zbarsky [:bz] (still a bit busy)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: 594645 696205
  Show dependency treegraph
 
Reported: 2011-11-01 19:30 PDT by Jesse Ruderman
Modified: 2011-11-04 03:06 PDT (History)
4 users (show)
bzbarsky: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (91 bytes, text/html)
2011-11-01 19:30 PDT, Jesse Ruderman
no flags Details
Fix assertion to not assert things that are just false. (3.14 KB, patch)
2011-11-01 21:34 PDT, Boris Zbarsky [:bz] (still a bit busy)
jonas: review+
Details | Diff | Splinter Review

Description Jesse Ruderman 2011-11-01 19:30:36 PDT
Created attachment 571223 [details]
testcase

> ###!!! ASSERTION: Unexpected root node: 'aRoot->IsElement() || aRoot->IsNodeOfType(nsINode::eDOCUMENT)', file content/base/src/nsGenericElement.cpp, line 5395

> nsGenericElement::doQuerySelector [content/base/src/nsGenericElement.cpp:5463]
> nsIDOMNodeSelector_QuerySelector [dom_quickstubs.cpp:5689]

I'm guessing this is a regression from:

changeset:   b068485e4cc2
user:        Boris Zbarsky
date:        Mon Oct 31 22:50:50 2011 -0400
summary:     Bug 696205 part 2.  Add a querySelector fast-path for selectors whose rightmost sequence of simple selectors contains an id.  r=sicking
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2011-11-01 19:35:20 PDT
Bah, indeed.  Fixing.
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2011-11-01 21:34:40 PDT
Created attachment 571236 [details] [diff] [review]
Fix assertion to not assert things that are just false.
Comment 3 Jesse Ruderman 2011-11-01 21:44:05 PDT
What's the loop index change for?
Comment 4 Boris Zbarsky [:bz] (still a bit busy) 2011-11-01 21:47:54 PDT
Fixes a compiler warning...
Comment 5 Boris Zbarsky [:bz] (still a bit busy) 2011-11-03 22:34:06 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/5883190e98aa
Comment 6 Ed Morley [:emorley] 2011-11-04 03:06:12 PDT
https://hg.mozilla.org/mozilla-central/rev/5883190e98aa

Note You need to log in before you can comment on or make changes to this bug.