Add ability to set '--track-origins=yes' for valgrind in a mozconfig file

RESOLVED INVALID

Status

Firefox Build System
General
--
enhancement
RESOLVED INVALID
7 years ago
5 months ago

People

(Reporter: Jesse Ruderman, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
--track-origins=yes can help track down uninitialized-memory bugs, but it's expensive enough that we probably only want to use the flag when we're actually trying to track down such a bug.
is this something that can go into a mozconfig?  If you have browser/config/mozconfigs/* mozconfigs in your push, try should use those.  Otherwise, if you are using the buildbot-configs version of the mozconfig, you could add it to mozconfig-extra-*.
(Reporter)

Comment 2

7 years ago
I'd be okay with something like that.  But --track-origins is an option for valgrind, so http://hg.mozilla.org/build/tools/file/tip/scripts/valgrind/valgrind.sh would need to be modified to look for it.
Ok, lets do that and allow people to specify that in their mozconfig.
Component: Release Engineering → Build Config
Product: mozilla.org → Core
QA Contact: release → build-config
Summary: Tryserver option to run valgrind with --track-origins=yes → Add ability to set '--track-origins=yes' for valgrind in a mozconfig file
Version: other → unspecified
This isn't something you'd set in a mozconfig. I don't understand what you're proposing.
(Reporter)

Comment 5

7 years ago
Also, http://hg.mozilla.org/build/tools/file/tip/scripts/valgrind/valgrind.sh creates its own mozconfig.

Maybe parts of valgrind.sh should be moved into mozilla-central? Or maybe valgrind.sh should look for a config file in mozilla-central/build/valgrind?
valgrind.sh turns on --track-origins=yes unconditionally.  mozconfigs don't seem relevant.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.