696362 - OpenDatabaseHelper's dtor can release objects on the wrong thread.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Something more like this, perhaps?

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 568741 [details] [diff] [review]
Patch

Review of attachment 568741 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/AsyncConnectionHelper.h
@@ +74,5 @@
>    HelperBase(IDBRequest* aRequest)
>      : mRequest(aRequest)
>    { }
>  
> +  ~HelperBase();

Definitely make this virtual.

@@ +197,5 @@
>     * Gives the subclass a chance to release any objects that must be released
>     * on the main thread, regardless of success or failure. Subclasses that
>     * implement this method *MUST* call the base class implementation as well.
>     */
> +   void ReleaseMainThreadObjects();

Why this change? Leave it virtual (aids understanding).

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/475896b92d6c

Comment 5

[Marco Bonardo [:mak]]

I think bug 696338 was caused by this?

Comment 6

[Marco Bonardo [:mak]]

ah sorry, missed the duping, somehow