696912 - Fix layout of download progress notification

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect, P4)

Description

[:Margaret Leibovic]

Bug 695461 added download progress notifications, but their layout is ugly. The layout looks good in XUL fennec, but the appearance somehow managed to regress when added to native fennec.

Comment 1

[Doug Turner (:dougt)]

margaret, can you own this?

Comment 2

[:Margaret Leibovic]

Sriram wrote a patch in bug 695461 that fixes this: https://bug695461.bugzilla.mozilla.org/attachment.cgi?id=569244

I landed it with this bug number, since this is the bug it's fixing:
https://hg.mozilla.org/projects/birch/rev/ff958ba524db

Comment 3

[:Margaret Leibovic]

Actually, this wasn't fixed. I can look into a way to fix it.

Comment 4

[:Margaret Leibovic]

I'm having trouble figuring this out - it seems like this was regressed by https://hg.mozilla.org/projects/birch/rev/9c8c4ee78c4e, which removed the textStyle/textSize rules.

Sriram, do you know if the android system styles are supposed to also take care of the these? Maybe we should keep our own size rules in there. I wonder what this looks like on other phones, but on my Atrix running 2.2.1 it looks pretty bad: http://margaretleibovic.com/tmp/download-notification.png.

Comment 5

[:Margaret Leibovic]

We figured out that this is just an issue on 2.2, and I believe Sriram suggested that we just needed to implement the new built-in notification styles ourselves for older versions of Android. However, phone got an update since then, so I actually don't have a device to develop on.

Comment 8

[Jan Henning [:JanH]]

I don't think this is relevant anymore with our current notification (and we're no longer supporting those Android versions, either).