69707 - need BeOS implementation of nsILocalFile::Launch and nsILocalFile::Reveal

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Gregor Rosenauer]

The "Launch" and "Reveal Location"-buttons seem to do nothing...

Comment 1

[Håkan Waara]

I believe this is a duplicate of bug 67001. Just change OS:All..

Comment 2

[kurros (Wade Majors)]

confirming.

Reveal needs to launch /system/Tracker with the parent folder that the file is in. Or for
bonus points:
   If the folder has a BEOS:PREF_APP mimetype, open the folder in that app.
   If the folder doesn't, use the default app for "application/x-vnd.Be-directory"
   (The user might not nessessarily use Tracker)

Launch runs the application (if it is one), else the default app for the filetype.

This bug depends on bug 69891

Comment 3

[Darin Fisher]

Why is this bug assigned to Networking:HTTP ?

Comment 4

[Gregor Rosenauer]

Sorry, my fault - I am a bit lost with the variety of Mozilla-modules;) (thought
downloading belonged to networking?)

Comment 5

[Yannick Koehler]

No more working on Bezilla

Comment 6

[Gregor Rosenauer]

Still true for 0.9.2/BeOS. BTW I'm sure there is already request for bundling
downloads in *one* single download-window, so I won't mention that here. :^)

Comment 7

[timeless]

//this code freely contributed by AnEvilYak
//this code is untested, anyone interested in testing it?
#include <Roster.h> 
#include <Entry.h>

NS_IMETHODIMP
nsLocalFile::Reveal()
{
  nsXPIDLCString path;
  GetPath(getter_Copies(path));
  BRoster roster;
  entry_ref ref;
  BPath beosPath (path);
  beosPath.GetParent (&beosPath);
  get_ref_for_path (beosPath.Path(), &ref);
  roster.Launch (&ref);
  return NS_OK;
}

NS_IMETHODIMP
nsLocalFile::Launch()
{
  nsXPIDLCString path;
  GetPath(getter_Copies(path));

  BRoster roster;
  entry_ref ref;
  get_ref_for_path (path, &ref);
  roster.Launch (&ref);

  return NS_OK;
}
//end of code

could someone please test this? it does make the assumption that path is a path 
to a file, so if you reveal /home/Desktop /home will open.  I didn't hunt for a 
way to select the file object. -- If anyone comes up w/ a way they can 
implement that later.

Comment 8

[timeless]

Attachment: people demand real patches...

Comment 9

[Christian "betzi" Hoffmann]

you have to use be_roster instead of your own instance. but it doesn't work for directories. I made a patch to launch tracker and pass the path as an argument. This is a dirty hack but it works. It would be better to use scripting. 

Comment 10

[Paul]

Attachment: this is a patch which was posted on a news group. I did a diff -u -d, instead of a plain diff. Needs review/testing

Comment 11

[timeless]

=> current maintainer.

Comment 12

[Paul]

Marking assigned.

Comment 13

[Daniel Switkin]

I was looking at the last patch:

+nsLocalFile::Reveal() 
+{ 
+  nsXPIDLCString path; 
+  GetPath(getter_Copies(path)); 
+  entry_ref ref; 
+  BPath beosPath (path); 
+  beosPath.GetParent (&beosPath); 
+  get_ref_for_path ("/boot/beos/system/Tracker", &ref); 
+  char* args[1]; 
+  args[0] = beosPath.Path(); 
+  be_roster->Launch (&ref, 1, args); 
+  return NS_OK; 
+}

If this is supposed to work like a normal command line app, argc should be 2, with the app 
name at argv[0] and the first argument at argv[1]. Anyway, better to do it with messaging 
as follows:

BMessage message(B_REFS_RECEIVED);
message.AddRef("refs", &ref);
BMessenger messenger("application/x-vnd.Be-TRAK");
messenger.SendMessage(&message);

where ref is an entry_ref to the parent folder.

Comment 14

[Paul]

Attachment: Update patch. Uses a BMessenger to lauch Tracker for reveal.

You mean something like this?

Created a new patch.  Now uses a BMessenger to tell Tracker to open the parent
directory for the file.

Comment 15

[Paul]

Who do I need to contact to get the latest patch reviewed, so I can check it in?

Also, the Launch button is always disabled, what causes that button to be
enabled/disabled?

Comment 16

[hacker formerly known as [e-mail]]

Comment on attachment 68682 [details] [diff] [review]
Update patch.  Uses a BMessenger to lauch Tracker for reveal.

Looks good to me. r=cls

Comment 17

[Paul]

The tree is currently closed for 0.9.9.  I have sent an email to
[e-mail] to get permission to check this patch in.

Comment 18

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.9

Comment 19

[Paul]

This has been checked in.  Marking resolved/fixed.  (Thanks for the aproval!)

Comment 20

[Sergei Dolgov]

Paul, was it really checked in, and if, where it disappeared?
http://bugzilla.mozilla.org/show_bug.cgi?id=145860

Comment 21

[Paul]

Sergei, look at the patch attached to this bug.  Then look at the file it was supposed
to modify.  As you can see, the patch WAS checked in.  I don't know what you mean by
this disappearing.  The bug you listed, though related, is not this bug.