697124 - Update the Context menu video items.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Philip Chee]

q.v. Firefox bugs:
Bug 681550 - Add ability to save current frame of video.
  (Typo fix) Bug 693099 - "Save Snapshot As" option on HTML5 videos creates PNG files with .JPG file extension.

Bug 481082 -  Video controls listen for stalled event and change the UI accordingly.

Bug 669260 - Add statistics overlay to video element.
  Bug 692640 - Video statistics text overlaps itself on small dimension videos.

Comment 1

[Philip Chee]

Attachment: Patch v1.0

> +  saveVideoFrameAsImage: function () {
> +    urlSecurityCheck(this.mediaURL, this.browser.contentPrincipal,

Couldn't get past urlSecurityCheck when using |this.target.nodePrincipal|

> +                     Components.interfaces.nsIScriptSecurityManager.DISALLOW_SCRIPT);

Firefox uses .DISALLOW_SCRIPT. I notice that we use .ALLOW_CHROME in this file instead.

>      return form.method == "get" || (form.method == "post" &&
>             form.enctype == "application/x-www-form-urlencoded");
>    },
> -  
> +

Only one instance of trailing whitespace, not worth another bug just to fix this.

> +html|table {
> +  font-family: Helvetica, Ariel, sans-serif;
> +  font-size: 11px;
> +  color: #FFFFFF;
> +  text-shadow:
> +    -1px -1px 0 #000000,
> +    1px -1px 0 #000000,
> +    -1px 1px 0 #000000,
> +    1px 1px 0 #000000;
> +  min-width: 100%;
> +  background: rgba(68,68,68,.7);
> +  table-layout: fixed;
> +  border-collapse: collapse;
> +  position: absolute;
> +}

Copied from winstripe. No idea what colours are appropriate for Modern.

>    skin/modern/global/media/throbber.png                            (/mozilla/toolkit/themes/winstripe/global/media/throbber.png)
> +  skin/modern/global/media/stalled.png                             (/mozilla/toolkit/themes/winstripe/global/media/stalled.png)

I see we directly copy some PNGs from winstripe so I'm doing the same here. stalled.png is already optimized AFAICT.

Comment 2

[[e-mail]]

Comment on attachment 569398 [details]
Patch v1.0

>+    var name = "";
var name = "snapshot.jpg";
Avoids having to test it later.

>+/* Statistics formatting */
>+html|*.statsDiv {
>+  position: relative;
>+}
>+html|td {
>+  height: 1em;
>+  max-height: 1em;
>+  padding: 0 2px;
>+}
>+html|table {
Nit: line spacing between blocks

>+  font-family: Helvetica, Ariel, sans-serif;
Typo: Arial

>+  text-shadow:
>+    -1px -1px 0 #000000,
>+    1px -1px 0 #000000,
>+    -1px 1px 0 #000000,
>+    1px 1px 0 #000000;
I'd prefer this on one line, even if it is slightly more than 80 characters.

>+  skin/modern/global/media/stalled.png                             (/mozilla/toolkit/themes/winstripe/global/media/stalled.png)
Please copy the file, in case toolkit changes things. r=me with those fixed.
[optipng won't touch the file because it's an APNG]

Comment 3

[Philip Chee]

Attachment: Patch v1.1 nits fixed. r=Neil

>>+    var name = "";
> var name = "snapshot.jpg";
> Avoids having to test it later.
Fixed.

>>+/* Statistics formatting */
>>+html|*.statsDiv {
>>+  position: relative;
>>+}
>>+html|td {
>>+  height: 1em;
>>+  max-height: 1em;
>>+  padding: 0 2px;
>>+}
>>+html|table {
> Nit: line spacing between blocks
Fixed.

>>+  font-family: Helvetica, Ariel, sans-serif;
> Typo: Arial
Fixed.

>>+  text-shadow:
>>+    -1px -1px 0 #000000,
>>+    1px -1px 0 #000000,
>>+    -1px 1px 0 #000000,
>>+    1px 1px 0 #000000;
> I'd prefer this on one line, even if it is slightly more than 80 characters.
Fixed.

>>+  skin/modern/global/media/stalled.png                             (/mozilla/toolkit/themes/winstripe/global/media/stalled.png)
> Please copy the file, in case toolkit changes things. r=me with those fixed.
> [optipng won't touch the file because it's an APNG]
Fixed.

Comment 4

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/a83e6190537e

Comment 5

[Serge Gautherie (:sgautherie)]

Update of test will happen in bug 712871.

Comment 6

[Justin Dolske [:Dolske]]

Please don't spam Firefox/Toolkit bugs with useless dependencies.