697150 - buildbot-configs/*: remove --disable-installer uses

Status: VERIFIED FIXED

(Release Engineering :: General, defect, P3)

Description

[Serge Gautherie (:sgautherie)]

(Noticed w.r.t. bug 604266 comment 21.)

Afaict, MOZ_INSTALLER (hence --disable-installer) applies to "OS_ARCH = WINNT" only.
Yet, 23 MacOSX mozconfig files have --disable-installer.
Could the latter be removed, or explained/documented?

Comment 1

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #0)
> (Noticed w.r.t. bug 604266 comment 21.)

Ignore this reference: this bug is part of bug 650322.

Comment 2

[Abhishek Singh]

Attachment: patch_A, mozilla-central part [Superseded by bug 650322]

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 572277 [details] [diff] [review]
patch_A, mozilla-central part
[Superseded by bug 650322]

Reviews for build changes need to be from a build peer:
https://wiki.mozilla.org/Modules/Core#Build_Config

Thanks :-)

Comment 4

[Rail Aliiev [:rail]]

See also http://hg.mozilla.org/mozilla-central/file/tip/mobile/config/mozconfigs/macosx-desktop/nightly. IIRC, we use this file for builds.

Comment 5

[Ed Morley [:emorley]]

Abhishek, if you could update your patch with author/commit message (following http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed) it will then be ready for checkin :-)

Comment 6

[Abhishek Singh]

keyword:checkin-needed

Comment 7

[Ed Morley [:emorley]]

Abhishek, the "checkin-needed" has to be added to the keywords field at the top of the page, rather than in the comment box, for it to be picked up in searches.

However, please see comment 5 before adding it - thanks :-)

Comment 8

[Ed Morley [:emorley]]

Please see comment 5 - thanks :-)

Comment 9

[Serge Gautherie (:sgautherie)]

I don't know what/when happened, but the OSX part is now done/WorksForMe.

Morphing this bug to the remaining (Windows) part.

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Remove 'ac_add_options --disable-installer' for XulRunner current branches [Checked in: Comment 13]

Bug 650322 did this for the in-tree files,
then I assume it's safe to do it for the buildbot-configs files too.
(Untested.)

Comment 11

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) Remove 'ac_add_options --disable-installer' for XulRunner older branches

I assume this should not be touched, but just in case it would be alright...

Comment 12

[(not currently active) Ted Mielczarek]

Comment on attachment 606930 [details] [diff] [review]
(Cv1) Remove 'ac_add_options --disable-installer' for XulRunner older branches

I don't think there's any reason to change this on older branches. We're not going to take any code changes there, so what does it matter? Let 'em rot.

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 606929 [details] [diff] [review]
(Bv1) Remove 'ac_add_options --disable-installer' for XulRunner current branches
[Checked in: Comment 13]

https://hg.mozilla.org/build/buildbot-configs/rev/39ffae5f5c4b

Comment 14

[Armen [:armenzg]]

This went live as of 9:15AM PDT approximately.

Comment 15

[Serge Gautherie (:sgautherie)]

V.Fixed, per MXR search,
except 3 occurrences per comment 12:
{
/buildbot-configs/mozilla2/win32/mozilla-1.9.2/xulrunner/mozconfig
    * line 9 -- ac_add_options --disable-installer
/buildbot-configs/mozilla2/win32/mozilla-2.0/xulrunner/mozconfig
    * line 9 -- ac_add_options --disable-installer
/buildbot-configs/mozilla2/win64/mozilla-2.0/xulrunner/mozconfig
    * line 9 -- ac_add_options --disable-installer
}