The default bug view has changed. See this FAQ.

Remove 'ac_add_options --disable-installer'

VERIFIED FIXED in mozilla12

Status

()

Core
Build Config
--
trivial
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: Abhishek Singh)

Tracking

Trunk
mozilla12
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [not-fennec-11], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Do this for all mozilla-central based builds.

Do this before pushing bug 604266, to be sure the latter won't break these builds.

***

I would suggest to start with
/buildbot-configs/mozilla2/win64/tryserver/xulrunner/mozconfig
    * line 9 -- ac_add_options --disable-installer
which was added in the meantime (bug 567154).
Flags: in-testsuite-
(Reporter)

Comment 1

6 years ago
This bug seems to be mostly affecting XulRunner.
(Reporter)

Updated

6 years ago
Depends on: 661403
(Reporter)

Comment 2

6 years ago
If 'ac_add_options --disable-installer' can't be "removed" from 'mozconfig',
then it should be "replaced" with 'MOZ_INSTALLER=' in 'confvars.sh'.

In the latter case, this bug depends on bug 661403.
Summary: Remove 'ac_add_options --disable-installer' → Replace/Remove 'ac_add_options --disable-installer'
(Reporter)

Updated

6 years ago
Depends on: 690369
(Reporter)

Comment 3

6 years ago
(In reply to Serge Gautherie (:sgautherie) from comment #2)

> If 'ac_add_options --disable-installer' can't be "removed" from 'mozconfig',
> then it should be "replaced" with 'MOZ_INSTALLER=' in 'confvars.sh'.

Ted, which way should this be done?

> In the latter case, this bug depends on bug 661403.

Blocking bugs have been fixed.
I'm not sure why that needs --disable-installer at all. Can we find out if that build works fine without it?
(Reporter)

Updated

6 years ago
Depends on: 697150

Updated

6 years ago
Assignee: nobody → abhishekkumarsingh.cse
Status: NEW → ASSIGNED
(Assignee)

Comment 5

6 years ago
Created attachment 572200 [details] [diff] [review]
'ac_add_options --disable-installer' removal, mozilla-central part
Attachment #572200 - Flags: review?(sgautherie.bz)
(Reporter)

Comment 6

6 years ago
Comment on attachment 572200 [details] [diff] [review]
'ac_add_options --disable-installer' removal, mozilla-central part

Review of attachment 572200 [details] [diff] [review]:
-----------------------------------------------------------------

Did you test or Try this patch?
Which repository are these paths in? (Is it 'build'?)

::: mobile/config/mozconfigs/macosx-desktop/nightly
@@ -5,5 @@
>  . $topsrcdir/build/macosx/mozconfig.leopard
>  ac_cv_visibility_pragma=no
>  
>  ac_add_options --disable-install-strip
> -ac_add_options --disable-installer

This one should probably be part of bug 697150.
Attachment #572200 - Flags: review?(sgautherie.bz) → review?(nrthomas)
(Assignee)

Comment 7

6 years ago
>>>>Which repository are these paths in? (Is it 'build'?)
>>>>::: mobile/config/mozconfigs/macosx-desktop/nightly

mobile is inside src directory(the source code which i downloaded using command "hg clone http://hg.mozilla.org/mozilla-central/ src")
Comment on attachment 572200 [details] [diff] [review]
'ac_add_options --disable-installer' removal, mozilla-central part

Like bug 697150 this should be reviewed by a peer of the Build Config module.

I don't personally know if windows xulrunner builds will be OK without --disable-installer. We don't normally call 'make installer' on the tinderbox machines, just 'make sdk' and 'make package', so it's possible something in 
  http://mxr.mozilla.org/mozilla-central/source/xulrunner/installer/windows/Makefile.in
is broken now.
Attachment #572200 - Flags: review?(nrthomas)
(Reporter)

Comment 9

5 years ago
(In reply to Abhishek Singh from comment #7)
> command "hg clone http://hg.mozilla.org/mozilla-central/ src")

Ah, right: I didn't know about these 3 m-c files.
http://mxr.mozilla.org/mozilla-central/search?string=--disable-installer&case=1&find=%2Fconfig%2Fmozconfigs%2F
(Reporter)

Updated

5 years ago
Attachment #572200 - Attachment description: 'ac_add_options --disable-installer' is removed. → removal, mozilla-central part
Attachment #572200 - Flags: review?(benjamin)
(Assignee)

Updated

5 years ago
Attachment #572200 - Flags: review?(benjamin) → review?(ted.mielczarek)
Attachment #572200 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Please could you tweak your hgrc to automatically add author info (guide here: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed) + add a commit message when attaching patches, since it makes pushing half a dozen checkin-neededs a lot easier. Thanks :-)
The patch doesn't apply anymore. mobile/config/... is now mobile/xul/config/...
Keywords: checkin-needed
Summary: Replace/Remove 'ac_add_options --disable-installer' → Remove 'ac_add_options --disable-installer'
(Reporter)

Updated

5 years ago
Whiteboard: [blocks bug 604266] [good first bug] → [patchlove] [blocks bug 604266] [good first bug]
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
See comment 11.
Keywords: checkin-needed
(Assignee)

Comment 13

5 years ago
Created attachment 590551 [details] [diff] [review]
'ac_add_options --disable-installer' removal, mozilla-central part
[Checked in: Comment 15]
Attachment #590551 - Flags: review?(ted.mielczarek)
Attachment #590551 - Flags: review?(ted.mielczarek) → review+
(Reporter)

Updated

5 years ago
Attachment #572200 - Attachment description: removal, mozilla-central part → 'ac_add_options --disable-installer' removal, mozilla-central part
Attachment #572200 - Attachment is obsolete: true
(Reporter)

Updated

5 years ago
Attachment #590551 - Attachment description: v1 → 'ac_add_options --disable-installer' removal, mozilla-central part
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/3732b1b4a0e0
Keywords: checkin-needed
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/3732b1b4a0e0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [patchlove] [blocks bug 604266] [good first bug] → [good first bug]
(Reporter)

Comment 16

5 years ago
(In reply to Ed Morley [:edmorley] from comment #15)

This bug is not fixed yet: see URL.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [good first bug] → [blocks bug 604266] [good first bug]
buildbot-configs are redundant with in-tree mozconfigs, surely?
(Reporter)

Comment 18

5 years ago
(In reply to Ed Morley [:edmorley] from comment #17)
> buildbot-configs are redundant with in-tree mozconfigs, surely?

Could very much be, but I didn't follow closely what happened wrt both places/uses.
If buildbot-configs/* files are redundant/obsolete, then they should just be removed.
(Reporter)

Updated

5 years ago
Attachment #590551 - Attachment description: 'ac_add_options --disable-installer' removal, mozilla-central part → 'ac_add_options --disable-installer' removal, mozilla-central part [Checked in: Comment 15]
(Reporter)

Comment 19

5 years ago
catlee, what about comment 18 after bug 558180?
Status: REOPENED → ASSIGNED
Depends on: 558180
(In reply to Serge Gautherie (:sgautherie) from comment #19)
> catlee, what about comment 18 after bug 558180?

Yes, after 558180 is closed those files can be removed. Right now some are used, some aren't.
(Reporter)

Comment 21

5 years ago
(In reply to Chris AtLee [:catlee] from comment #20)
> Yes, after 558180 is closed those files can be removed.

Then I would think the current bug is (still) valid as is:
in one place or the other, this option needs to be removed eventually.
Whiteboard: [blocks bug 604266] [good first bug] → [blocks bug 604266] [good first bug][not-fennec-11]
(Reporter)

Updated

5 years ago
Depends on: 736739
(Reporter)

Updated

5 years ago
Blocks: 736739
No longer depends on: 736739
(Reporter)

Comment 22

5 years ago
V.Fixed, per MXR search.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Whiteboard: [blocks bug 604266] [good first bug][not-fennec-11] → [not-fennec-11]
(Reporter)

Updated

5 years ago
Severity: normal → trivial
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.