Clean up nsDataObj::SetText on Windows

RESOLVED FIXED in mozilla10

Status

()

Core
Widget: Win32
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla10
x86
Windows Vista
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Although I look HG/CVS log by http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/windows/nsDataObj.cpp&rev=1.90, I cannot make sense why nsDataObj::SetText() doesn't return E_FAIL simply.  Also, FALSE (=0) means S_OK (=0), so this is broken.
(Assignee)

Comment 1

5 years ago
Created attachment 570587 [details] [diff] [review]
fix
Assignee: nobody → m_kato
Attachment #570587 - Flags: review?(jmathies)
(Assignee)

Updated

5 years ago
Blocks: 113234

Updated

5 years ago
Attachment #570587 - Flags: review?(jmathies) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/470ed3885e3c
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/470ed3885e3c

I love it when people make this file less awful.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.