Last Comment Bug 697336 - Clean up nsDataObj::SetText on Windows
: Clean up nsDataObj::SetText on Windows
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget: Win32 (show other bugs)
: Trunk
: x86 Windows Vista
: -- normal (vote)
: mozilla10
Assigned To: Makoto Kato [:m_kato]
:
:
Mentors:
Depends on:
Blocks: 113234 535860
  Show dependency treegraph
 
Reported: 2011-10-25 19:41 PDT by Makoto Kato [:m_kato]
Modified: 2011-11-01 07:42 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.10 KB, patch)
2011-10-30 18:46 PDT, Makoto Kato [:m_kato]
jmathies: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] 2011-10-25 19:41:08 PDT
Although I look HG/CVS log by http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/windows/nsDataObj.cpp&rev=1.90, I cannot make sense why nsDataObj::SetText() doesn't return E_FAIL simply.  Also, FALSE (=0) means S_OK (=0), so this is broken.
Comment 1 Makoto Kato [:m_kato] 2011-10-30 18:46:25 PDT
Created attachment 570587 [details] [diff] [review]
fix
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-11-01 07:42:30 PDT
https://hg.mozilla.org/mozilla-central/rev/470ed3885e3c

I love it when people make this file less awful.

Note You need to log in before you can comment on or make changes to this bug.