697367 - Bogus data table row if the statistics for the day aren't available yet

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Statistics, defect, P4)

Description

[Wladimir Palant]

On https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/statistics/usage/applications/?last=30 I see under "Application usage by Date" a line "Wed, Oct 26, 2011" - zeros in all columns. I know of course that the statistics for today will only be calculated in a few hours. But why is that row being displayed then?

Comment 1

[Potch [:potch]]

We currently show empty rows as zeros for all columns if other rows on the page have data. I think it's probably worth it to fix the no data cells to indicate as much (and also disallow seeing today, since it always has no data). I'll land those changes in the next few days.

Comment 2

[Wil Clouser [:clouserw]]

> I'll land those changes in the next few days.

Not showing today wfm.  I always hope we'll have closer to real-time stats, but I suppose we'll cross that bridge when we get there.  (in 2055)

Comment 3

[Wladimir Palant]

(In reply to Wil Clouser [:clouserw] from comment #2)
> Not showing today wfm.

You need to look at it before the daily stats calculation runs. Or even simpler (seeing that it shows October 27th line even when it is still 26th in Mountain View) - I change the date on my computer to November 27th and all the sudden "last 30 days" shows only empty rows. Maybe it should use server time to decide which day is "today"? Client time can have very significant skew.

Daily users still show up with zero for October 26th but this seems to be an unrelated issue (data processing, not UI).

Comment 4

[Wil Clouser [:clouserw]]

A simpler solution could be to check if the latest row is all zeroes and remove it from the dataset if it is (server side).  That way you won't see today if it hasn't processed yet, but if stats fail to process for several days you'll start seeing zeroes (because we are only removing 1 row).  How does that sound?

Comment 5

[Wil Clouser [:clouserw]]

I think potch said this was fixed - not sure?  It's a P4.

Comment 6

[Potch [:potch]]

We no longer show today. We're not accounting for time zone variability in what "today" means, but all the stats are PST anyway, so I'm declaring this edge-case okay.