697390 - Using switch-to-tab before Panorama moves new tabs around

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

STR:

1) Have at least two groups with at least one tab per group
2) Restart Firefox
3) Open a new tab
4) Use switch-to-tab to jump to another group's tab

Actual result:

The tab from (3) was moved to the group we just switched to.

Expected result:

The new tab should of course not move around.

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 569922 [details] [diff] [review]
v1

Review of attachment 569922 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, nice solution!

Comment 3

[Raymond Lee [:raymondlee]]

Attachment: Patch for checkin

Pushed to try and waiting for results
https://tbpl.mozilla.org/?tree=Try&rev=bc4f4694ae7b

Comment 4

[Raymond Lee [:raymondlee]]

(In reply to Raymond Lee [:raymondlee] from comment #3)
> Pushed to try and waiting for results
> https://tbpl.mozilla.org/?tree=Try&rev=bc4f4694ae7b

There is a leak on OS X debug.  Investigating

Comment 5

[Raymond Lee [:raymondlee]]

(In reply to Raymond Lee [:raymondlee] from comment #4)
> (In reply to Raymond Lee [:raymondlee] from comment #3)
> > Pushed to try and waiting for results
> > https://tbpl.mozilla.org/?tree=Try&rev=bc4f4694ae7b
> 
> There is a leak on OS X debug.  Investigating

It turned out that it's caused by other patch.

The leak does't happen in this push.
https://tbpl.mozilla.org/?tree=Try&rev=58e8625d9c24

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/56c72e3c1f03

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/56c72e3c1f03