697453 - Allow setting report submission preference via XPCOM.

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Philip Chee]

Reference Firefox Bug 540532: allow setting report submission preference via XPCOM.

Comment 1

[Philip Chee]

Attachment: Patch v1.0

Adds a checkbox in the preferences UI to expose if crash reports should be submitted or not.

Comment 2

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/1a8d3a88db18

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Came here from Help bug 698038. I wondered why the whole Advanced pref pane was empty on Linux, and especially why the new group box that was added through this bug was missing. Turns out it's because this is false on Linux:

NS_SHELLSERVICE_CID in Components.classes

So, looking at base bug 540532 it seems that there's an implementation for Linux in the back-end (but not Mac, FWIW). Was that an oversight? If it was I think we should move the CrashReportsCheck() call to Startup().

Comment 4

[Philip Chee]

> Was that an oversight?
In a way. I was porting the Firefox patch and at that time they wrapped the crash reports checkbox inside a shell service check:

http://hg.mozilla.org/mozilla-central/rev/b8586e71aa93#l2.10

But I missed Bug 652657 Comment 44 since we haven't yet implemented the front end for telemetry:

>>diff --git a/browser/components/preferences/advanced.xul b/browser/components/preferences/advanced.xul
> 
>> #ifdef MOZ_CRASHREPORTER
>>             <checkbox id="submitCrashesBox" flex="1"
>>                       oncommand="gAdvancedPane.updateSubmitCrashes();"
>>                       label="&submitCrashes.label;" accesskey="&submitCrashes.accesskey;"/>
>> #endif
>>+#endif
> 
> Technically I think this should be outside of the HAVE_SHELL_SERVICE ifdef, but I guess you don't need to make that change here.

So please file a new bug?