Closed Bug 697453 Opened 13 years ago Closed 13 years ago

Allow setting report submission preference via XPCOM.

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set
normal

Tracking

(seamonkey2.7 fixed)

RESOLVED FIXED
seamonkey2.7
Tracking Status
seamonkey2.7 --- fixed

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file)

Reference Firefox Bug 540532: allow setting report submission preference via XPCOM.
Attached patch Patch v1.0Splinter Review
Adds a checkbox in the preferences UI to expose if crash reports should be submitted or not.
Attachment #569690 - Flags: review?(iann_bugzilla)
Attachment #569690 - Flags: review?(iann_bugzilla) → review+
Blocks: 698038
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/1a8d3a88db18
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.7
Came here from Help bug 698038. I wondered why the whole Advanced pref pane was empty on Linux, and especially why the new group box that was added through this bug was missing. Turns out it's because this is false on Linux:

NS_SHELLSERVICE_CID in Components.classes

So, looking at base bug 540532 it seems that there's an implementation for Linux in the back-end (but not Mac, FWIW). Was that an oversight? If it was I think we should move the CrashReportsCheck() call to Startup().
> Was that an oversight?
In a way. I was porting the Firefox patch and at that time they wrapped the crash reports checkbox inside a shell service check:

http://hg.mozilla.org/mozilla-central/rev/b8586e71aa93#l2.10

But I missed Bug 652657 Comment 44 since we haven't yet implemented the front end for telemetry:

>>diff --git a/browser/components/preferences/advanced.xul b/browser/components/preferences/advanced.xul
> 
>> #ifdef MOZ_CRASHREPORTER
>>             <checkbox id="submitCrashesBox" flex="1"
>>                       oncommand="gAdvancedPane.updateSubmitCrashes();"
>>                       label="&submitCrashes.label;" accesskey="&submitCrashes.accesskey;"/>
>> #endif
>>+#endif
> 
> Technically I think this should be outside of the HAVE_SHELL_SERVICE ifdef, but I guess you don't need to make that change here.

So please file a new bug?
You need to log in before you can comment on or make changes to this bug.